You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered ☂️
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Critical issues exclude the plugin from fresh development environments, accept HTTP 200 without validating connection acknowledgement, and leave orphaned remote connections after URL changes or failed batches.
This PR reworks OneLogs connections between governing and brand sites, moving cross-site requests to the server and updating the settings and logs interfaces.
Changes:
Introduces dedicated connection controllers and a shared remote client, keeping stored brand-site keys out of browser responses.
Updates settings and logs screens to use WordPress apiFetch, normalized URLs, and clearer failure messages.
Expands PHP and JavaScript coverage and adjusts plugin startup and development configuration.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Critical validation and connection-lifecycle flaws can erase configured sites, falsely report successful connections, and leave remote sites connected without corresponding local records.
Please ignore stale request completions before clearing the logs. If a slow brand-site request is pending, the user switches back to the governing site, and that site's logs load successfully, a later failure from the old brand-site request executes this block and erases the current logs while showing the old site's error. Track a request generation or cancel superseded requests, and guard both success and failure state updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Related Issue(s):
How
AI Disclosure
Testing Instructions
Screenshots
Additional Info
Checklist