Skip to content

Settings: AI agents card above General Settings, notice heading capitalised - #2386

Merged
subodhr258 merged 2 commits into
mainfrom
fix/ai-agents-notice-copy
Nov 17, 2026
Merged

subodhr258 merged 2 commits into
mainfrom
fix/ai-agents-notice-copy

Conversation

@subodhr258

@subodhr258 subodhr258 commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

Two small 2.10.0 UI fixes, for release ticket https://github.com/rtCamp/godam-plugin-wp/issues/106:

  1. Save button placement. In GoDAM > Settings > General, the AI agents (MCP) card was added below the General Settings Save button, so Save floated between two cards and read as the save for the AI agents card (which saves on its own). The AI agents card now sits above General Settings, so Save is the last thing on the page under the card it saves, as on every other settings tab.
  2. Notice copy. "New: use GoDAM from your AI agent." becomes "New: Use GoDAM from your AI agent."

Where to look

  1. Card order (pages/godam/components/tabs/GeneralSettings/GeneralSettings.jsx:102-105)
    { /* Saves on its own, so it sits above the card that the Save button below belongs to. */ }
    <AiAgentsSettings />
    
    <Panel header={ __( 'General Settings', 'godam' ) } ...>
    Check: the Save button still saves only folder organisation and GTM tracking; the AI agents switch still saves immediately.

Everything else is mechanical: the one-word copy change in AiAgentsNotice.jsx:57 and the regenerated POT (the new msgid plus moved line numbers).

UI evidence

GoDAM > Settings > General on godam-multisite.local with the MCP Adapter 0.7.1 active, same window size, logged in as an administrator. Before is a build of main (e96f235), after is this branch (e640da1).

Before: the heading reads "New: use GoDAM…", and Save sits between General Settings and the AI agents (MCP) card, so it reads as the save for that card.

Before: Save button between the General Settings card and the AI agents card

After: the heading reads "New: Use GoDAM…", the AI agents (MCP) card comes first, and Save is last, under General Settings.

After: AI agents card first, General Settings second, Save at the bottom

Both pages log the same 3 console errors, so none come from this change.

Earlier check, same page:

  • Before: Save sat between the General Settings card and the AI agents (MCP) card, nearly touching the AI agents card.
  • After: notice reads "New: Use GoDAM from your AI agent."; the AI agents (MCP) card is first, General Settings second, and Save is at the bottom right under General Settings.
  • Save still works: turned GTM tracking on, saved, reloaded, the option was stored as true (then set back).

How to test

  1. GoDAM > Settings > General with the MCP Adapter active: the notice heading starts "New: Use", the AI agents card is above General Settings, Save is last.
  2. Change GTM tracking, Save, reload: the change is kept. Flip "Let AI agents connect to GoDAM": it saves without the Save button.

Risk

risk: low because it only reorders two cards and changes one word; no logic changes.

@subodhr258 subodhr258 added the risk: low QA automation only (Dependabot fixes, copy, CSS) label Nov 17, 2026
@github-actions

Copy link
Copy Markdown

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
13 0 13

⚠️ Warnings (13)

📁 readme.txt (1 warning)
📍 Line 🔖 Check 💬 Message
0 mismatched_plugin_name Plugin name "GoDAM - Video Hosting for LMS & Online Courses" is different from the name declared in plugin header "GoDAM".
📁 assets/build/pages/video-editor.min.js (1 warning)
📍 Line 🔖 Check 💬 Message
2 react_removed_api This file calls "ReactDOM.findDOMNode", which was removed in React 19 and stops working once WordPress upgrades React. Use a ref on the element instead.
📁 assets/build/css/main.css (1 warning)
📍 Line 🔖 Check 💬 Message
0 EnqueuedStylesScope This style is being loaded in all contexts.
📁 assets/src/libs/analytics.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/11/17/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
📁 assets/build/js/main.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/11/17/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

@subodhr258
subodhr258 merged commit 418cd64 into main Nov 17, 2026
8 checks passed
@subodhr258
subodhr258 deleted the fix/ai-agents-notice-copy branch November 17, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low QA automation only (Dependabot fixes, copy, CSS)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants