Repository navigation
feat(vscode): publish alpine-x64 and alpine-arm64 VSIX targets - #88
Merged
Merged
Conversation
VS Code installs a platform-specific extension only on an exact target match, so VS Code Server on Alpine (musl) hosts could not install rstack.rstack at all. Two more release legs ship the musl yuku-parser binding, which rslib.config.mts now selects for alpine-* targets.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…get mapping The review found no caller for host musl detection: the release matrix always sets VSCE_TARGET and CI builds run on glibc runners. The binding-suffix mapping and the release install step are now one expression each.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2a94d4012
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The Linux VSIX targets differ only by libc, so a lookup table states the mapping as data instead of a nested ternary. Behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VS Code installs a platform-specific extension only on an exact target match, so
rstack.rstackcould not be installed by VS Code Server on Alpine (musl) hosts. This addsalpine-x64andalpine-arm64release legs.rslib.config.mtsmapslinux-*targets to thelinux-*-gnuYuku binding andalpine-*tolinux-*-musl. A local build on musl Linux setsVSCE_TARGET=alpine-<arch>explicitly.release.ymladds the two legs and always lists"libc":["current","musl"]in pnpm'ssupportedArchitectures, so the Alpine legs get the-muslbinding. On the glibc Linux legs that is a few extra optional downloads; macOS/Windows legs are unaffected because pnpm still filters by os.scripts/packageTargets.mjsand thepackages/vscode/AGENTS.mdgotcha cover the new targets.Verified locally: packaged
alpine-x64,alpine-arm64andlinux-x64VSIXs each carry exactly one binding (linux-x64-musl,linux-arm64-musl,linux-x64-gnu), and both musl bindings load innode:22-alpinecontainers.Related Links
Checklist