Repository navigation
feat: use auto config loader with bundled jiti - #565
Merged
Merged
Conversation
Deploying rstack-cli with
|
| Latest commit: |
f930d78
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3302b610.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-feat-auto-config.rstack-cli.pages.dev |
chenjiahan
marked this pull request as ready for review
October 13, 2026 13:16
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94546924b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rstack currently requires native config loading, which rejects TypeScript syntax such as enums. Allow configs to fall back to the jiti bundled with Rsbuild.
Changes
Register a lazy jiti importer and switch the shared config loader to
auto. Before each jiti attempt, discard definitions from the failed native attempt in the active config session so they do not cause duplicate-definition errors. Duplicate definitions within a single attempt remain errors, and concurrent config sessions remain isolated.Add coverage for unsupported TypeScript syntax and repeated fallback after partial definitions. Build, native build, lint/type/format checks, and the full local suite pass (427 passed, 1 skipped). The declared Node.js support range is unchanged.
Config-dependency tracking on the jiti path remains a follow-up: it currently returns no dependencies. Resetting registered definitions does not undo other side effects from config execution.