Skip to content

fix: keep refresh hooks available after module execution - #96

Merged
LingyuCoder merged 1 commit into
mainfrom
seal/fix-prefresh-refresh-sig-fallback
Oct 26, 2026
Merged

LingyuCoder merged 1 commit into
mainfrom
seal/fix-prefresh-refresh-sig-fallback

Conversation

@LingyuCoder

Copy link
Copy Markdown
Contributor

Summary

  • Keep $RefreshSig$ callable after module factories complete, so components declared during render can refresh correctly.
  • Use a safe root fallback for $RefreshReg$ instead of retaining a module-scoped registration function with a stale module ID.
  • Add HMR regression coverage for a nested component using useState.

Fixes #24.

Test Plan

  • pnpm build
  • pnpm test (27 tests passed)
  • pnpm exec rs lint --type-check

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T10:46:26.075347Z 30df92b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@LingyuCoder
LingyuCoder merged commit 746ee7e into main Oct 26, 2026
4 checks passed
@LingyuCoder
LingyuCoder deleted the seal/fix-prefresh-refresh-sig-fallback branch October 26, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: $RefreshSig$ and $RefreshReg$ become undefined during the hot reload process

2 participants