Repository navigation
chore(deps): update dependency fastify to v5 [security] - #18
renovate[bot] wants to merge 1 commit into
Conversation
da7f627 to
a4f4577
Compare
a0549a8 to
5c91885
Compare
217504a to
851e287
Compare
851e287 to
a456520
Compare
1b2d1cb to
a431a7e
Compare
a431a7e to
1b03332
Compare
230e77b to
5af2f99
Compare
6fb586e to
cc9daf2
Compare
6254b99 to
0fe6748
Compare
0fe6748 to
1a0603f
Compare
1a0603f to
8ff7fe0
Compare
8ff7fe0 to
f2624b5
Compare
📝 WalkthroughWalkthroughThis pull request updates the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 42: The package currently depends on fastify "^5.0.0", which introduces
breaking API changes; either pin fastify to a v3/v4-compatible version or
migrate code to v5: update all fastify.listen(port) calls to fastify.listen({
port }), audit all fastify.register(...) usages and plugin imports to use v4+
naming (e.g., replace fastify-static with `@fastify/static`) and ensure
fastify-graceful-shutdown and `@types/fastify-static` are version-compatible or
replaced, and run a code search for ".listen(" without an options object and for
"fastify.register" to locate and fix remaining call sites.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a734e73c-622c-4dea-b0e0-8415aa45b687
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
| "@types/fastify-static": "^2.2.3", | ||
| "@types/node": "^14.18.63", | ||
| "fastify": "^3.29.5", | ||
| "fastify": "^5.0.0", |
There was a problem hiding this comment.
Critical breaking changes in Fastify v5 will cause test failures.
This major version jump from v3 to v5 introduces multiple breaking changes that affect the codebase:
-
listen()API signature changed (v4+): The test helper atsri-plugin/examples/wsi-test-helper.js:103callsawait fastify.listen(port), but Fastify v4+ requires an options object:await fastify.listen({ port }). This will throw a TypeError at runtime. -
Plugin compatibility concerns: The related plugins
fastify-static@^4.7.0(line 44) andfastify-graceful-shutdown@^4.0.1(line 43) need verification for Fastify v5 compatibility. Additionally,fastify-staticwas renamed to@fastify/staticin the Fastify v4 ecosystem. -
Type definitions:
@types/fastify-static@^2.2.3(line 40) may not provide correct types for Fastify v5.
Run the following script to verify Fastify usage patterns and check for additional breaking changes:
#!/bin/bash
# Description: Find all Fastify usage in the codebase and check for v3-style API calls
echo "=== Searching for Fastify instantiation and listen() calls ==="
rg -n -A 5 -B 2 'Fastify\s*\(' --type=js
echo -e "\n=== Searching for .listen( calls that may need migration ==="
rg -n -P '\.listen\s*\(\s*(?!{)' --type=js
echo -e "\n=== Searching for fastify plugin registrations ==="
rg -n 'fastify\.register\(' --type=js -A 2Additionally, search the web for migration guidance:
Fastify v3 to v5 migration guide breaking changes
fastify-static v4 compatibility with Fastify v5
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 42, The package currently depends on fastify "^5.0.0",
which introduces breaking API changes; either pin fastify to a v3/v4-compatible
version or migrate code to v5: update all fastify.listen(port) calls to
fastify.listen({ port }), audit all fastify.register(...) usages and plugin
imports to use v4+ naming (e.g., replace fastify-static with `@fastify/static`)
and ensure fastify-graceful-shutdown and `@types/fastify-static` are
version-compatible or replaced, and run a code search for ".listen(" without an
options object and for "fastify.register" to locate and fix remaining call
sites.
f2624b5 to
d0cb603
Compare
d0cb603 to
06c103d
Compare
e2bb9be to
2f52e76
Compare
fd4679c to
8116b62
Compare
abb08c0 to
b05c710
Compare
26b21ee to
d64962d
Compare
d64962d to
225e217
Compare
84bf50a to
c94a0b5
Compare
f1ba0d5 to
ba2fae7
Compare
ba2fae7 to
c9ac585
Compare
c9ac585 to
ef338a2
Compare
ef338a2 to
3b089b9
Compare
3b089b9 to
32b154b
Compare
32b154b to
216e1dc
Compare
Note
This PR body was truncated due to platform limits.
This PR contains the following updates:
^3.29.5→^5.0.0Fastify's Content-Type header tab character allows body validation bypass
CVE-2026-25223 / GHSA-jx2c-rxcm-jvmq
More information
Details
Impact
A validation bypass vulnerability exists in Fastify where request body validation schemas specified by Content-Type can be completely circumvented. By appending a tab character (
\t) followed by arbitrary content to the Content-Type header, attackers can bypass body validation while the server still processes the body as the original content type.For example, a request with
Content-Type: application/json\tawill bypass JSON schema validation but still be parsed as JSON.This vulnerability affects all Fastify users who rely on Content-Type-based body validation schemas to enforce data integrity or security constraints. The concrete impact depends on the handler implementation and the level of trust placed in the validated request body, but at the library level, this allows complete bypass of body validation for any handler using Content-Type-discriminated schemas.
This issue is a regression or missed edge case from the fix for a previously reported vulnerability.
Patches
This vulnerability has been patched in Fastify v5.7.2. All users should upgrade to this version or later immediately.
Workarounds
If upgrading is not immediately possible, user can implement a custom
onRequesthook to reject requests containing tab characters in the Content-Type header:Resources
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
fastify: request.protocol and request.host Spoofable via X-Forwarded-Proto/Host from Untrusted Connections
CVE-2026-3635 / GHSA-444r-cwp2-x5xf
More information
Details
Summary
When
trustProxyis configured with a restrictive trust function (e.g., a specific IP liketrustProxy: '10.0.0.1', a subnet, a hop count, or a custom function), therequest.protocolandrequest.hostgetters readX-Forwarded-ProtoandX-Forwarded-Hostheaders from any connection — including connections from untrusted IPs. This allows an attacker connecting directly to Fastify (bypassing the proxy) to spoof both the protocol and host seen by the application.Affected Versions
fastify <= 5.8.2
Impact
Applications using
request.protocolorrequest.hostfor security decisions (HTTPS enforcement, secure cookie flags, CSRF origin checks, URL construction, host-based routing) are affected whentrustProxyis configured with a restrictive trust function.When
trustProxy: true(trust everything), bothhostandprotocoltrust all forwarded headers — this is expected behavior. The vulnerability only manifests with restrictive trust configurations.Severity
CVSS:3.1/AV:A/AC:H/PR:N/UI:N/S:C/C:H/I:N/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
fastify vulnerable to schema validation bypass via root primitive coercion mismatch
CVE-2026-18504 / GHSA-w2qp-rph6-63g4
More information
Details
Impact
fastifybefore 5.12.1, when a route uses a root-level primitive body schema (for example an integer with a minimum and maximum) and the default type coercion, validates the coerced value but exposes the original, uncoerced value to the route handler. For example, a JSON body"10"is coerced to the number10and passes an integer 1 to 10 schema, butrequest.bodystays the string"10". An application that trusts the validated type is handed a value that did not satisfy the schema, which can bypass limits the application enforces on that typed value. Object and array body schemas are not affected, they coerce their members in place.Patches
Upgrade to
fastify5.12.1.Workarounds
Until you can upgrade, avoid relying on the validated type of a root primitive body. Wrap the value in an object schema (object properties are coerced in place), for example accept
{ "value": 10 }and readrequest.body.value, or re-check the type in the handler.Severity
CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:L/I:L/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
fastify vulnerable to request validation bypass via skipped boolean false schemas
CVE-2026-84469 / GHSA-hwr6-493r-vm6h
More information
Details
Impact
Fastify decided whether to validate a request part by checking its schema for JavaScript truthiness. JSON Schema Draft 7 defines the boolean
falseas a valid schema that rejects every instance, but becausefalseis falsy, a route that setbody,querystring,params, orheaderstofalsehad that part left uncompiled: no validator was attached and the request reached the handler. An application that usedfalseas a deny-all schema to make a route unreachable was therefore fully bypassed, and an unauthenticated remote client could reach the handler with any input. The same applied to the documentedqueryalias forquerystring. This is a complete bypass rather than a weak-schema issue, sincefalseis the strongest JSON Schema assertion and must always fail.Patches
Request-part schemas are now selected by an explicit presence check rather than truthiness, so a boolean
false(ortrue) schema is compiled and enforced, including through thequeryalias. Patched in fastify5.12.2. The fix is also included in the6.0.0release.Workarounds
If upgrading is not immediately possible, express a deny-all request schema with an always-failing object schema instead of the boolean
false(for example{ "not": {} }), or reject the request in anonRequesthook.Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
fastify vulnerable to request body replacement via an async validation result collision
CVE-2026-84504 / GHSA-667r-xxjv-c9mm
More information
Details
Impact
Fastify runs a route's validator and, for a result shaped like
{ value, error }, unwraps it: anerrorbecomes a validation failure andvaluereplaces the request part. This convention is intended for synchronous custom compilers (for example Joi). A JSON Schema$asyncvalidator, however, resolves with the validated data itself, so Fastify applied the same unwrapping to it. If a request part validated by an$asyncschema contains avalueproperty, Fastify replaced the whole request part with that nested value before the handler ran, so avalueorerrorproperty in the payload was attacker-controlled. An application that dispatches operations from the validated request body could then act on data that never satisfied the route schema, leading to unauthorized state changes or disclosure. Reaching the vulnerable path requires the route to use an$asyncrequest schema.Patches
Fastify no longer treats an asynchronous validation result as a
{ value, error }wrapper: an async validator's resolved value is used only to determine pass or fail, and it can no longer replace the request part or inject an error. The synchronous custom-compiler contract is unchanged. Patched in fastify5.12.2and6.0.0.Workarounds
If upgrading is not immediately possible, avoid
$asyncrequest schemas, or perform the security-sensitive check in anonRequestorpreHandlerhook rather than relying on the schema-validated request part. Custom async validator compilers should signal failure by throwing (rejecting) rather than returning an{ error }object.Severity
CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
fastify/fastify (fastify)
v5.12.2Compare Source
What's Changed
Full Changelog: fastify/fastify@v5.12.1...v5.12.2
v5.12.1Compare Source
What's Changed
Full Changelog: fastify/fastify@v5.12.0...v5.12.1
v5.12.0Compare Source
What's Changed
Reply.prototype.mediaTypeby @github-actions[bot] in #6946undefinedfor invalid media types by @github-actions[bot] in #6947Full Changelog: fastify/fastify@v5.11.3...v5.12.0
v5.11.3Compare Source
What's Changed
New Contributors
Full Changelog: fastify/fastify@v5.11.2...v5.11.3
v5.11.2Compare Source
What's Changed
fastify.jsFull Changelog: fastify/fastify@v5.11.1...v5.11.2
v5.11.1Compare Source
What's Changed
New Contributors
Full Changelog: fastify/fastify@v5.11.0...v5.11.1
v5.11.0Compare Source
What's Changed
Content-Typeparameter values by @aquie00t in #6865New Contributors
Full Changelog: fastify/fastify@v5.10.0...v5.11.0
v5.10.0Compare Source
What's Changed
jsonandcharsetin reply.send by @climba03003 in #6830New Contributors
Full Changelog: fastify/fastify@v5.9.0...v5.10.0
v5.9.0Compare Source
What's Changed
findwithsomeinhasKeyfor correct boolean semantics by @aquie00t in #6759AssertionErrorwithFST_ERR_PLUGIN_DEPENDENCY_NOT_REGISTEREDincheckDependenciesby @aquie00t in #6774New Contributors
Full Changelog: fastify/fastify@v5.8.5...v5.9.0
v5.8.5Compare Source
This fixes CVE CVE-2026-33806 GHSA-247c-9743-5963.
What's Changed
New Contributors
Full Changelog: fastify/fastify@v5.8.4...v5.8.5
v5.8.4Compare Source
Full Changelog: fastify/fastify@v5.8.3...v5.8.4
v5.8.3Compare Source
This fixes CVE CVE-2026-3635 GHSA-444r-cwp2-x5xf.
What's Changed
New Contributors
Full Changelog: fastify/fastify@v5.8.2...v5.8.3
v5.8.2[Compare S
Configuration
📅 Schedule: (in timezone Asia/Shanghai)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.