Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Member
Author
|
flasky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eco-CI source
API > Server.getFreePort > should return the port when the port is specifiedfails in beforeEach withNo available ports foundattests/helpers/get-random-port.js:60, called bygetRandomPorts(8).Fix
Clamp the start to the last valid contiguous block and wrap through every valid start once before reporting exhaustion. Keep the 15000–45000 bounds, availability checks, reservation map, and production code unchanged. Add regressions for an upper-boundary random start and an already-reserved upper block.
Validation
Passed on macOS arm64, Node 24.20.0, pnpm 12.11.2, with the current main lockfile:
pnpm install --frozen-lockfilepnpm exec rs test run tests/e2e/get-random-port.test.js— 2 passed.pnpm exec rs test run tests/e2e/api.test.js -t Server.getFreePort— 7 passed; 10 unrelated tests filtered out.pnpm check— lint and formatting passed.pnpm test:type— build and both TypeScript resolution fixtures passed.git diff --checkA deterministic isolated helper harness reproduced the upper-boundary and occupied-tail failures before the fix and passed afterward. Not run: full E2E suite, Linux CI, or the exact Eco-CI Rspack artifact; this change only affects test port allocation.