Skip to content

test: search the full random port range - #270

Closed
SoonIter wants to merge 1 commit into
mainfrom
codex/eco-ci-auto/port-range-wrap
Closed

SoonIter wants to merge 1 commit into
mainfrom
codex/eco-ci-auto/port-range-wrap

Conversation

@SoonIter

Copy link
Copy Markdown
Member

🤖 AUTO-GENERATED by the daily-rspack-eco-ci-triage automation from an Rstack ecosystem CI failure.

Eco-CI source

Fix

Clamp the start to the last valid contiguous block and wrap through every valid start once before reporting exhaustion. Keep the 15000–45000 bounds, availability checks, reservation map, and production code unchanged. Add regressions for an upper-boundary random start and an already-reserved upper block.

Validation

Passed on macOS arm64, Node 24.20.0, pnpm 12.11.2, with the current main lockfile:

  • pnpm install --frozen-lockfile
  • pnpm exec rs test run tests/e2e/get-random-port.test.js — 2 passed.
  • pnpm exec rs test run tests/e2e/api.test.js -t Server.getFreePort — 7 passed; 10 unrelated tests filtered out.
  • pnpm check — lint and formatting passed.
  • pnpm test:type — build and both TypeScript resolution fixtures passed.
  • git diff --check

A deterministic isolated helper harness reproduced the upper-boundary and occupied-tail failures before the fix and passed afterward. Not run: full E2E suite, Linux CI, or the exact Eco-CI Rspack artifact; this change only affects test port allocation.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 01:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T01:06:00.456561Z d3a4f1b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@SoonIter SoonIter closed this Oct 22, 2026
@SoonIter

Copy link
Copy Markdown
Member Author

flasky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants