Open
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is one of the earliest lexers written in the project, and it definitely shows its age. It was using all manner of large joined regex, and lookaheads that were frankly unnecessary.
I've introduced a special
:newlinestate which is pushed at every newline. The Cython lexer has also been adjusted to be compatible with this.The lookaheads that were kept are for
caseandmatch, which are not entirely possible to lex correctly without doing a full parse. This approach works for the most common cases, and a few uncommon ones, but it is possible to break it with a specially crafted string literal inside a case pattern or match statement. In the worst case, though,caseandmatchwill be highlighted as Name, and the lexer will recover.Mojo was also edited to use the
:funcnamestate after itsfnkeyword.