fix(tui): surface ink, sticky hover, wrap, and session chrome polish - #286
Open
rotemmiz wants to merge 7 commits into
Open
fix(tui): surface ink, sticky hover, wrap, and session chrome polish#286rotemmiz wants to merge 7 commits into
rotemmiz wants to merge 7 commits into
Conversation
…rfaces Unstyled " " between styled spans was refilled with stream Bg and read as white gaps on sidebar/mode-line; cursor line lacked Fg so the active row washed out. Co-authored-by: Cursor <cursoragent@cursor.com>
Enable bubbles DynamicHeight so newline growth clamps YOffset; without it height-1 scroll stuck after grow and hid the first line. Co-authored-by: Cursor <cursoragent@cursor.com>
Pulling one event per Update forced a full body rebuild per token; a 16ms flush window plus delta coalesce matches opencode/Android and collapses multi-second same-session catch-up into one frame. Co-authored-by: Cursor <cursoragent@cursor.com>
Pin nested panel text to On(surface) so modals/slash/diff drop stream-bg slabs; keep ctrl+p hover without scrolling the list; wrap stream/chrome copy; align slash descriptions; add selection toggle and related UX fixes. Co-authored-by: Cursor <cursoragent@cursor.com>
…284) * feat(tui): align session composer chrome with opencode layout (08g) Fold mode/model into the elevated prompt box and put usage/hints on the under-box row so the empty input bar reads tall like opencode; tighten sidebar padding and use max(6, h/3) as the textarea growth cap. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(tui): address 08g review — acPopupY and composer inner width Stop double-counting the hint row in autocomplete Y; size the textarea to barWidth-5 (border+padding under lipgloss v2); align resize with the guttered stream column; tighten tests and mode-line gap. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(tui): only gutter composer width on the session screen Splash has no stream gutter; applying it there narrowed the home composer. Also truncate sidebar cwd for Padding(1,2). Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
…285) * feat(tui): polish session chrome theme, title, footer, agents (08h) Pin composer/textarea to BgElev, clamp near-white light elevations, wrap sidebar titles, restore green • footer, always show mode-line model info, and rename TASKS→AGENTS. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(tui): drop dead footerMicroLogo; tighten 08h footer test Review follow-up: remove unused micro-logo helper and assert the green dot chip is not flush on the last sidebar row. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
Fg-only lipgloss styles left canvas cells with nil Bg; on light terminals those rendered as black rectangles behind sidebar, mode line, and tool chrome. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Styles.On(surface)so ctrl+p / slash / diff panes no longer paint stream-bg glyph slabs on elevated surfaces (all themes).modalListOffsticky window; keyboard still scrolls).PaddingLeft; align slash descriptions; optional terminal text selection (disable mouse capture); sidebar path/branch wrap + context stats polish; related diff/split and streaming fixes on this branch.Test plan
go test ./internal/tui/ -skip Opcode42Parity/— no black/white text slabs; descriptions column-aligned in/…Made with Cursor