Support loading parameter files for all matching nodes - #1278
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Support loading parameter files for all matching nodes#1278sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Allow `ros2 param load PARAMETER_FILE` to apply a parameter file to every running node matched by its node and wildcard entries while preserving the existing node-specific form. Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow
ros2 param load PARAMETER_FILEto apply a parameter file to all currently running nodes matched by that file.The existing
ros2 param load NODE_NAME PARAMETER_FILEform is unchanged.System-wide loading reuses
rclpy.parameter.parameter_dict_from_yaml_file()per discovered node, so exact node entries, namespaces, and wildcard rules use the same matching behavior as normal parameter loading. The command also excludes its own temporary direct discovery node from wildcard targets.Fixes #778.
Is this user-facing behavior change?
Yes.
ros2 param loadcan now omit the node name to load a multi-node parameter file across matching running nodes.Additional Information
Added focused coverage for the new one-positional CLI form, multi-node matching, unmatched nodes, and the no-match error path.
Did you use Generative AI?
Yes. AI was used to assist with tests.