Wait for daemon publisher discovery in topic CLI tests - #1277
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Wait for daemon publisher discovery in topic CLI tests#1277sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the race tracked in #1093 by waiting until the CLI daemon has discovered the test publishers before launching
ros2 topic bw,delay, orhz.The existing waits use
self.node.count_publishers(), which immediately sees the publisher created by that same node. That does not guarantee the daemon used by the CLI has discovered the endpoint yet, which is the failure mode seen with Zenoh.Use
NodeStrategyto querycount_publishers()through the running CLI daemon instead. Apply the same synchronization to the basic, multi-topic, and--allbw/hz paths.Fixes #1093.
Is this user-facing behavior change?
No. This only makes the CLI integration tests wait for the same discovery state that the commands rely on.
Additional Information
The retry remains bounded and the tests still fail if the daemon does not discover the publishers.
Did you use Generative AI?
Yes. AI was used to assist with tests.