Retry daemon socket acquisition after shutdown tail - #1274
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Retry daemon socket acquisition after shutdown tail#1274sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Distinguish a live daemon from a temporarily occupied daemon address. When a spawn timeout is provided and the daemon is no longer serving, wait for the address to become reusable and retry the bind once. Add focused tests for live-daemon, shutdown-tail, and non-blocking behavior. Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the remaining failure mode in #1229.
shutdown_daemon()now waits for the XML-RPC address to become reusable, but a daemon that exits through its inactivity timeout can still stop serving before the process releases the listening socket. During that window,spawn_daemon()currently interpretsEADDRINUSEas an already-running daemon and returnsFalse.When a spawn timeout is provided, distinguish that shutdown-tail case from a live daemon, wait for the address to become reusable, and retry the bind once.
Existing behavior is preserved when:
Testing
Added focused unit tests for:
Did you use Generative AI?
Yes. AI was used to assist with tests.