Add ros2 pkg depends verb - #1268
Open
Miko997 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Miko Parkkinen <141511110+Miko997@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
fujitatomoya
left a comment
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
what is the difference between this and ros2 pkg xml | grep? for maintainability, we do not want to maintain the overlapped features for sure.
besides, #44 is originally created almost 10 years ago. i am not sure if there are any requests from community... at least, it's been 10 years...
|
Would the outcome be different than ? |
Collaborator
|
@Miko997 a couple of questions here before starting review, please have them checked out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
ros2 pkg depends <package_name>to print the package's direct declared dependencies.The verb reads the installed
package.xml, evaluates dependency conditions against the current environment, and prints unique dependency names in sorted order. Recursive lookup and dependency-type filters are outside this PR.Addresses #44
Is this user-facing behavior change?
Yes.
ros2 pkgnow provides adependsverb for installed packages.Additional Information
Validation:
ros2pkgtests excluding unavailablexmllint: 6 passed, 1 deselectedgit diff --checkxmllintwas not available in the test environment. This PR does not change XML files.