Test ros2 lifecycle output streams - #1266
Conversation
Signed-off-by: Miko Parkkinen <141511110+Miko997@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
|
Validated the current head |
| text=lifecycle_command.stderr, | ||
| strict=False | ||
| ) | ||
| assert not lifecycle_command.stdout |
There was a problem hiding this comment.
one minor concern here.
stderr on the success path could be brittle. rmw implementations (RCI ConnextDDS, CycloneDDS) occasionally emit warnings to stderr that are unrelated to the command's correctness — e.g., discovery or shared-memory warnings depending on the CI host.
let's run the CI to make sure this is not the case.
|
Pulls: #1266
|
2 participants
Description
Verify that
ros2 lifecycle setwrites command errors to stderr and successful transitions to stdout. Also require the unused stream to remain empty so regressions cannot pass through combined process output.Addresses #484
Is this user-facing behavior change?
No.
Did you use Generative AI?
No.
Additional Information
Validation:
python3 -m compileall -q ros2lifecycle/test/test_cli.pygit diff --check origin/rolling...HEADThe full ROS integration test was not run locally because this environment does not contain ROS 2 or
colcon.