Skip to content

address compiler warning from ignored rmw_publish and rmw_take_event. #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fujitatomoya merged 1 commit into from
Sep 3, 2026
+5 −2
Merged

address compiler warning from ignored rmw_publish and rmw_take_event. #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions test_rmw_implementation/test/test_event_message_lost_deadlock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
#include <cstdlib>
#include <iostream>
#include <thread>
#include <tuple>

#include "rcutils/allocator.h"
#include "rcutils/strdup.h"
Expand Down Expand Up @@ -145,7 +146,8 @@ TEST_F(TestEventMessageLostDeadlock, take_event_does_not_deadlock_with_on_sample
test_msgs__msg__BasicTypes msg;
test_msgs__msg__BasicTypes__init(&msg);
while (!stop.load(std::memory_order_relaxed)) {
(void)rmw_publish(pub, &msg, nullptr);
// Failures are irrelevant here; the flood must keep running.
std::ignore = rmw_publish(pub, &msg, nullptr);
}
test_msgs__msg__BasicTypes__fini(&msg);
});
Expand All @@ -156,7 +158,8 @@ TEST_F(TestEventMessageLostDeadlock, take_event_does_not_deadlock_with_on_sample
rmw_message_lost_status_t status;
bool taken = false;
while (!stop.load(std::memory_order_relaxed)) {
(void)rmw_take_event(&event, &status, &taken);
// Failures are irrelevant here; the loop must keep taking.
std::ignore = rmw_take_event(&event, &status, &taken);
take_iters.fetch_add(1, std::memory_order_relaxed);
}
});
Expand Down