Show launch argument names in print-description output - #999
Open
official-burak wants to merge 1 commit into
Open
Show launch argument names in print-description output#999official-burak wants to merge 1 commit into
official-burak wants to merge 1 commit into
Conversation
--print-description currently renders DeclareLaunchArgument and OpaqueFunction with the default object repr, so operators only see addresses instead of argument names or the wrapped callable. Signed-off-by: Burak Keskin <official.burak@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
--print-descriptionshowDeclareLaunchArgumentnames, defaults, and descriptionsOpaqueFunctionby the wrapped callableLaunchDescriptionwith its entity countDescription
Fixes #975
LaunchIntrospector.format_launch_description(whatros2 launch --print-descriptionuses) fell through toAction('<... object at 0x...>')for most actions. Declared arguments therefore printed an address instead of the argument name.Give those actions a useful
__repr__(Action.describe()already returns that) and usedescribe()in the introspector fallback.Test evidence
Before:
After:
pytest test/launch/test_launch_introspector.py test/launch/actions/test_declare_launch_argument.pyfailed first (missinguse_sim_time/generate_nodesin the tree), then passed after the change (10 passed).