[virtualx] use win context for CopyPixmap and SetOpacity methods#21924
Draft
linev wants to merge 8 commits intoroot-project:masterfrom
Draft
[virtualx] use win context for CopyPixmap and SetOpacity methods#21924linev wants to merge 8 commits intoroot-project:masterfrom
CopyPixmap and SetOpacity methods#21924linev wants to merge 8 commits intoroot-project:masterfrom
Conversation
Global gCws context was used Provide short docu for new methods
Let use window context when calling these methods. These are central methods to emulate pad opacity without real support of alpha channel in X11
Test Results 22 files 22 suites 3d 6h 56m 39s ⏱️ For more details on these failures, see this check. Results for commit 227e00b. ♻️ This comment has been updated with latest results. |
There are several pad fill attributes which only relevant for pad. It is fill style 4000..4100 or fillcolor 10 for fillstyle 3000..3100 Move all these special attribute only to TPad::PaintBorder to exclude misuse of these attributes in different classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two methods used to emulate transparency of the sub-pads on X11.
Therefore provide
SetOpacityWandCopyPixmapWmethods for all platforms.And use these methods from
TPadPainterclassTGLPadPainteruse absolutely different approach and not invoke these methods directlyIMPORTANT!
Move handling of pad opacity fill styles 4000..4100 from
TPad::PaintBoxtoTPad::PaintBorder.Remove all pad-special fill styles handling from
TPad::PaintBox- now it only dedicated for normal painting.Makes logic much clear now.
Probably peace of the code emulating transparency can be moved later to
TPadPainterclass.