[ntuple] allow passing opts to CreateAttributeSet, reuse otherwise#21918
Open
silverweed wants to merge 1 commit intoroot-project:masterfrom
Open
[ntuple] allow passing opts to CreateAttributeSet, reuse otherwise#21918silverweed wants to merge 1 commit intoroot-project:masterfrom
silverweed wants to merge 1 commit intoroot-project:masterfrom
Conversation
Currently CreateAttributeSet is just passing an empty WriteOptions struct to sink->CloneAsHidden(). This PR changes CloneAsHidden()'s signature to accept an optional instead of a const ref and, if nothing is passed, the "parent" sink's options are reused. This means e.g. that by default CreateAttributeSet will preserve the same compression as the main RNTuple, which is what you would intuitively expect.
Test Results 22 files 22 suites 3d 5h 53m 35s ⏱️ Results for commit cc0eb48. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently CreateAttributeSet is just passing an empty WriteOptions struct to sink->CloneAsHidden().
This PR changes CloneAsHidden()'s signature to accept an optional instead of a const ref and, if nothing is passed, the "parent" sink's options are reused.
This means e.g. that by default CreateAttributeSet will preserve the same compression as the main RNTuple, which is what you would intuitively expect.
Checklist: