Fix Clean task to drop COLMAP metadata instead of whitelist#12
Open
jlegrand62 wants to merge 1 commit into
Open
Fix Clean task to drop COLMAP metadata instead of whitelist#12jlegrand62 wants to merge 1 commit into
jlegrand62 wants to merge 1 commit into
Conversation
- Introduce `COLMAP_MD` in `romitask/src/romitask/task.py` as the list of metadata added by the Colmap task - Remove the legacy `IMAGES_MD` whitelist and the `keep_metadata` luigi parameter from `Clean` - Delete the `_merge_metadata_keep_list` helper used for whitelist merging - Update `_clean_images_metadata` to drop blacklisted keys (`COLMAP_MD`) instead of retaining a whitelist - Adjust the `run` method to use the new blacklist approach and remove the now‑unused metadata whitelist generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the following changes to the
Cleantask:COLMAP_MDlist inromitask/task.pyto specify metadata added by the Colmap task.IMAGES_MDwhitelist and thekeep_metadataLuigi parameter._merge_metadata_keep_listhelper used for whitelist merging._clean_images_metadatato drop blacklisted keys (COLMAP_MD) rather than retaining a whitelist.runmethod to use the new blacklist approach and removed the now‑unused whitelist generation logic.