Skip to content

chore: document ROCKETADMIN_COOKIE_DOMAIN list format in app config (… - #1900

Merged
Artuomka merged 1 commit into
mainfrom
backend_cookie_domain_touch
Nov 2, 2026
Merged

Artuomka merged 1 commit into
mainfrom
backend_cookie_domain_touch

Conversation

@Artuomka

@Artuomka Artuomka commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

A one-line comment on the config entry. The change touches the backend so the next merge rebuilds and redeploys the service with the new cookie domain list.

Summary by CodeRabbit

  • Documentation
    • Clarified that the cookie domain setting accepts a comma-separated list of registrable domains and should use the same value in SaaS. This provides clearer guidance on the expected configuration format and the value to use across environments.

…plan 84)

A one-line comment on the config entry. The change touches the backend so the
next merge rebuilds and redeploys the service with the new cookie domain list.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@Artuomka
Artuomka enabled auto-merge November 2, 2026 11:23
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b81ffeab-965b-4842-8e89-031419df0346
Commits

Reviewing files that changed from the base of the PR and between 5b48c25 and 5d01614.

Files selected for processing: 1
  • backend/src/shared/config/app-config.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

A comment in AppConfig documents ROCKETADMIN_COOKIE_DOMAIN as a comma-separated list of registrable domains and states that SaaS must use the same value. No behavior changes are described.

Changes: Cookie domain configuration

Layer / File(s) Summary
Document cookie domain value
backend/src/shared/config/app-config.ts
A comment describes ROCKETADMIN_COOKIE_DOMAIN as a comma-separated list of registrable domains and notes that SaaS must use the same value.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 5d016

This documentation-only change is mergeable with no actionable risk requiring resolution.

Pre-merge checks: Passed 6
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: documenting the list format for ROCKETADMIN_COOKIE_DOMAIN in the app configuration.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Security Check Passed PASS. The pull request changes only one comment in backend/src/shared/config/app-config.ts. It does not change configuration parsing, cookie matching, cookie attributes, authentication, or authoriza…
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Full details: Security Check

Explanation

PASS. The pull request changes only one comment in backend/src/shared/config/app-config.ts. It does not change configuration parsing, cookie matching, cookie attributes, authentication, or authorization behavior. The reviewed diff introduces no new security weakness or malicious-actor path.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit reads the config note,
Commas mark each domain afloat.
Registrable names line up in rows,
SaaS keeps the same value it shows.
Then off the rabbit bounds to burrow.

@Artuomka
Artuomka merged commit 2821d88 into main Nov 2, 2026
16 of 17 checks passed
@Artuomka
Artuomka deleted the backend_cookie_domain_touch branch November 2, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant