Conversation
…ncluded sign-branch.sh only looks at origin, so it cannot sign a PR whose branch lives on a contributor's fork. sign-pr.sh resolves the PR's head repo and branch with gh, fetches and pushes by URL (so a fork works when the PR allows maintainer edits), and otherwise rebuilds commits the same way: identical trees, you as author, signed, original author date, original author kept as a Co-authored-by trailer. With no PR number it offers an arrow-key picker of the ten most recently updated open PRs.
Contributor
Author
|
Replaced by #44, which adds PR support to sign-branch.sh instead of a separate script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sign-branch.shonly looks atorigin, so it cannot sign a PR whose branch lives on a contributor's fork (for example rocicorp/mono#6683, onpawarren/mono).scripts/sign-pr.sh [<pr-number>] [--repo owner/name] [--yes] [--no-push]:gh, fetches and pushes by URL, so a fork works when the PR allows maintainer edits. Refuses closed PRs and forks that disallow edits.sign-branch.shdoes:git commit-treefrom the original tree (asserted identical), you as author, signed, original author date, original author kept as aCo-authored-by:trailer. Commits already authored and signed by you keep their SHA; merges are refused.--yes.--no-pushleaves the chain atrefs/sign-pr/<n>and prints the push command.sign-branch.sh.--if-exists addIfDifferent; see fix(scripts): keep the original author when a Co-authored-by already exists #42 for the same fix insign-branch.sh.Used to sign rocicorp/mono#6683.