Skip to content

ci: add workflow tests and fix concurrency group - #846

Closed
sumitsaini03 wants to merge 1 commit into
roc-streaming:masterfrom
sumitsaini03:fix/testingYaml
Closed

ci: add workflow tests and fix concurrency group#846
sumitsaini03 wants to merge 1 commit into
roc-streaming:masterfrom
sumitsaini03:fix/testingYaml

Conversation

@sumitsaini03

Copy link
Copy Markdown
  • tests/test_build_workflow.py: matrix/script consistency, dup job names, concurrency group, structural sanity

  • requirements-dev.txt: PyYAML for the workflow tests

  • build.yml: replace 'pull_request.number || github.ref' with workflow+event_name+ref so non-PR triggers don't share a slot under cancel-in-progress: true

- tests/test_build_workflow.py: matrix/script consistency, dup job names, concurrency group, structural sanity

- requirements-dev.txt: PyYAML for the workflow tests

- build.yml: replace 'pull_request.number || github.ref' with workflow+event_name+ref so non-PR triggers don't share a slot under cancel-in-progress: true
@rocstreaming-bot rocstreaming-bot added the contrib PR not by a maintainer label Jun 27, 2026
@rocstreaming-bot

Copy link
Copy Markdown

🤖 Pull request description does not have a link to an issue.
If there is a related issue, please add it to the description using any of the supported formats.

@rocstreaming-bot

Copy link
Copy Markdown

🤖 Pull request is not targeted to develop branch, which is usually wrong.
If this was not intentional, please rebase on fresh develop branch, force-push, and re-target pull request using github web interface. Remember to use rebase with force-push instead of regular merge.

@baranovmv

Copy link
Copy Markdown
Member

Thanks for contribution. Unfortunately I'm closing the PR as it lacks

  • motivation for the changes -- I mean, some of it might be useful, but it'd be better to bring an explicit explanation what lead you to introducing these changes, an issue would be perfect, but not required;
  • and coherency -- keep PR small and related to a single purpose, fix or feature

@baranovmv baranovmv closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contrib PR not by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants