fix: replace bare except clauses with specific exception types#31
Open
AmSach wants to merge 1 commit into
Open
fix: replace bare except clauses with specific exception types#31AmSach wants to merge 1 commit into
AmSach wants to merge 1 commit into
Conversation
Bare `except:` clauses catch BaseException, including SystemExit and KeyboardInterrupt, which can hide real bugs and make the code harder to debug. They also catch any unrelated exception type, masking programming errors. This change narrows the exception handlers to the specific exceptions that the called functions can actually raise: - `socket.inet_pton` raises OSError (or its subclass) for invalid addresses; ValueError can also occur with bad input. - `socket.gethostbyname` raises socket.gaierror for DNS failures, and UnicodeError/ValueError for invalid domain inputs. This makes error handling more precise and PEP 8 compliant (BLE001 / W0702).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found two bare
except:clauses inadminrestrict/middleware.pythat catchBaseException(includingSystemExitandKeyboardInterrupt) and any unrelated exception type, which can hide real bugs and mask programming errors.Changes
is_valid_ip—socket.inet_ptonraisesOSError(or subclass) for invalid addresses;ValueErrorcan occur for bad input. Narrowed to(OSError, ValueError).get_ip_address_for_fqdn—socket.gethostbynameraisessocket.gaierrorfor DNS failures, andUnicodeError/ValueErrorfor invalid domain inputs. Narrowed to(socket.gaierror, UnicodeError, ValueError).Diff
This makes the error handling PEP 8 compliant (BLE001 / W0702) and prevents accidentally swallowing control-flow exceptions.
— Sent via @AmSach bot