Repository navigation
Quick fix for the Additional make build arguments issue - #124
Merged
Merged
Conversation
…o take parameter addMakeArgs string. toolbox/supsisim/supsisim/scene.py: Modified function Scene.codegen and Scene.generateCCode to include Make arguments similar to C defines.
Hishmann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is a PR for the issue #100.
I wanted to use this feature for a flexible build process but the dialog box was not doing anything with the given input since it had not been implemented yet. So I did some small reuse and modifications in the code so that the generated Makefile can have the additional Make arguments included in it similar to how the additional C defines are included. I am opening a pull request to see if the modification seems okay for use.