Repository navigation
fix(ios): rewrite the module map path of rnmapbox-maps on react-native 0.87+ - #4370
Merged
Merged
Conversation
…odule name differs
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the Swift Package Manager opt-in build (#4368), apps on react-native 0.87+ (0.87, 0.88 and current nightlies) fail to build with
module map file '${PODS_CONFIGURATION_BUILD_DIR}/rnmapbox-maps/rnmapbox_maps.modulemap' not found.Since react/react-native#57602, RN's
rewrite_aggregate_modulemap_referencesrewrites<Pod>/<Pod>.modulemapreferences, assuming the module name equals the pod name. Forrnmapbox-mapsthe module isrnmapbox_maps, so the path isn't rewritten. This hooks RN's rewrite to also rewrite our module map path; it's a no-op on RN < 0.87 and once RN is fixed upstream in react/react-native#59182.Tested with an RN nightly app (Debug build + launch, Release archive), an RN 0.88.0 app (Debug build + launch), and the 0.84 example app.
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing
Not a runtime issue: create an app with react-native 0.87+ and
$RNMapboxMapsSwiftPackageManager = truein the Podfile, runpod install, and build.