Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/__tests__/app.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -223,14 +223,21 @@ describe('source maps', () => {
const clickSpy = vi.spyOn(fileUploadButton, 'click')

// Other keys must not open the file selector
fireEvent.keyDown(fileUploadButton, { code: 'KeyA' })
fireEvent.keyDown(fileUploadButton, { code: 'KeyA', key: 'a' })
expect(clickSpy).not.toHaveBeenCalled()

// Fire the keydown event with Enter
fireEvent.keyDown(fileUploadButton, { code: 'Enter' })
// Buttons activate on Enter, NumpadEnter, and Space
fireEvent.keyDown(fileUploadButton, { code: 'Enter', key: 'Enter' })
expect(clickSpy).toHaveBeenCalledTimes(1)

// Verify that the keydown handler called click() on the current target
expect(clickSpy).toHaveBeenCalledOnce()
fireEvent.keyDown(fileUploadButton, { code: 'NumpadEnter', key: 'Enter' })
expect(clickSpy).toHaveBeenCalledTimes(2)

// Space must activate the button and not scroll the page,
// so the default must be prevented.
const spaceNotPrevented = fireEvent.keyDown(fileUploadButton, { code: 'Space', key: ' ' })
expect(clickSpy).toHaveBeenCalledTimes(3)
expect(spaceNotPrevented).toBe(false)

clickSpy.mockRestore()
})
Expand Down
6 changes: 5 additions & 1 deletion src/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,11 @@ export default function App() {
htmlFor="sourcemap-file-input"
id="file-upload-button"
onKeyDown={event => {
if (event.code === 'Enter') {
// Buttons activate on Enter and Space; `key` (unlike
// `code`) also matches NumpadEnter.
if (event.key === 'Enter' || event.key === ' ') {
// Space must not scroll the page.
event.preventDefault()
event.currentTarget.click()
}
}}
Expand Down
Loading