Preserve unparsed stack trace lines in the transformed output - #39
Merged
Conversation
Deploying sourcemap-tools with
|
| Latest commit: |
a2d3894
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2fc5faa.sourcemap-tools.pages.dev |
| Branch Preview URL: | https://preserve-unparsed-stack-trac.sourcemap-tools.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 213 209 -4
Branches 53 55 +2
=========================================
- Hits 213 209 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
Problem
The transformed output was fully re-generated from parsed frames, so:
Caused by:chains, etc.) were silently dropped,Fix
The transformation is now line-based:
StackTraceparses the input line by line and keeps{ raw, frame }pairs (lines) instead of a detachedmessage+framessplit.transformonly replaces lines whose frames were successfully mapped through a source map; every other line — messages, unparsed lines, unmapped frames — passes through verbatim in its original position.A nice consequence: with no matching source maps the output now equals the input exactly, so the
reconstructedfixture (a lossy re-rendering of the stack trace) is gone. TheresultandafterDeleteIndexfixtures did not change.Tests
Two new tests (
unparsed linessuite): a multi-line error message survives the transformation, and an async marker plus aCaused by:chain pass through in place between mapped frames. Both fail onmainwithout the fix (verified viagit stash). Existing expectations for unmapped frames were updated to the new pass-through behavior.Coverage stays at 100%.