Memoize stack trace parsing and transformation - #38
Merged
Conversation
Deploying sourcemap-tools with
|
| Latest commit: |
937597c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a61b9d9b.sourcemap-tools.pages.dev |
| Branch Preview URL: | https://memoize-stack-trace-transfor.sourcemap-tools.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 213 213
Branches 53 53
=========================================
Hits 213 213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30
Problem
StackTrace.createandtransform(which walks every frame and callsoriginalPositionForon the consumer) ran on every render ofApp— including renders caused by unrelated state, e.g. every keystroke in the source map textarea or a theme toggle. For large stack traces with several source maps this causes noticeable input lag.Fix
Wrapped both steps in
useMemo:stackTraceInputValue,sourceMapsand the parsedstackTrace.Debouncing from the issue was left out: with memoization the expensive work only runs when its actual inputs change, and re-parsing on each stack trace keystroke is the desired behavior (the result pane updates live).
Tests
Two integration tests (
memoizationsuite): after entering a stack trace and uploading source maps, an unrelated re-render (typing into the source map textarea) must not callStackTrace.createor the consumer'soriginalPositionForagain.originalPositionForis spied on via the consumer prototype, same technique as the existingdestroyspy. Both tests fail onmainwithout the fix (verified viagit stash).Correctness of the memo dependencies is already covered by existing tests: the result updates after editing the stack trace, uploading, and deleting source maps.
Coverage stays at 100%.