Discard stale async results in the source map textarea handler - #37
Merged
Conversation
Deploying sourcemap-tools with
|
| Latest commit: |
fdc5f40
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8087c552.sourcemap-tools.pages.dev |
| Branch Preview URL: | https://fix-sourcemap-input-race.sourcemap-tools.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 208 213 +5
Branches 52 53 +1
=========================================
+ Hits 208 213 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25
What
handleSourceMapTextAreaChangeis async: every input event kicks offSourceMap.create, and nothing guaranteed the results applied in order. A slow parse could resolve after the user had already typed something else and then:How
Each handler invocation takes a monotonically increasing id from a ref; after
await SourceMap.create(...)the result is applied only if the invocation is still the latest. A superseded-but-parsed source map has its consumer destroyed so it does not leak (same lifecycle rule as #23).Tests
New
source map input racesuite delays the firstSourceMap.createcall so a later input finishes first, covering both orderings:Both fail against the previous handler and pass with the fix. Full suite 31/31, coverage stays at 100%.