test: add async API coverage tests#258
Merged
Merged
Conversation
Tests for the non-deprecated async API surface that previously had zero test coverage: getValueAsync, createDefaultInstanceAsync, createInstanceByNameAsync, createBlankInstanceAsync, defaultArtboardViewModelAsync, getArtboardCountAsync, getPropertiesAsync, and async list operations.
mfazekas
added a commit
that referenced
this pull request
May 19, 2026
## Summary Adds 31 harness tests for the non-deprecated async API that previously had zero test coverage. Existing tests only exercise the deprecated sync methods (`.value`, `viewModelByName`, `createInstanceByName`, etc.) — this fills the gap for the intended async replacements. ## What's covered - `createDefaultInstanceAsync`, `createInstanceByNameAsync`, `createBlankInstanceAsync` - `defaultArtboardViewModelAsync`, `getArtboardCountAsync`, `getArtboardNamesAsync` - `getPropertiesAsync`, `getPropertyCountAsync`, `getInstanceCountAsync` - `getValueAsync()` + `set()` round-trip for all 5 property types (number, string, boolean, color, enum) - `viewModelAsync` for nested ViewModel access - Async list operations: `getLengthAsync`, `getInstanceAtAsync`, `addInstanceAsync`, `removeInstanceAtAsync`, `swapAsync` ## Test plan - [x] `yarn test:harness:ios -- __tests__/async-api.harness.ts` — 31/31 pass - [x] Full suite `yarn test:harness:ios` — 136 pass (no regressions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 31 harness tests for the non-deprecated async API that previously had zero test coverage. Existing tests only exercise the deprecated sync methods (
.value,viewModelByName,createInstanceByName, etc.) — this fills the gap for the intended async replacements.What's covered
createDefaultInstanceAsync,createInstanceByNameAsync,createBlankInstanceAsyncdefaultArtboardViewModelAsync,getArtboardCountAsync,getArtboardNamesAsyncgetPropertiesAsync,getPropertyCountAsync,getInstanceCountAsyncgetValueAsync()+set()round-trip for all 5 property types (number, string, boolean, color, enum)viewModelAsyncfor nested ViewModel accessgetLengthAsync,getInstanceAtAsync,addInstanceAsync,removeInstanceAtAsync,swapAsyncTest plan
yarn test:harness:ios -- __tests__/async-api.harness.ts— 31/31 passyarn test:harness:ios— 136 pass (no regressions)