Skip to content

chore: refresh the cMPT devbox Custody spec - #60

Merged
pdp2121 merged 1 commit into
mainfrom
chore/refresh-cmpt-devbox-spec
Nov 5, 2026
Merged

pdp2121 merged 1 commit into
mainfrom
chore/refresh-cmpt-devbox-spec

Conversation

@pdp2121

@pdp2121 pdp2121 commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

Re-vendors the cMPT devbox's public and internal specs and regenerates the types. The devbox still reports 1.36.2, but it has been redeployed with new APIs:

  • XLS-68 sponsorship:
    • SponsorshipSetAsSponsor / SponsorshipSetAsSponsee XRPL operations;
    • an optional sponsorship block on any XRPL transaction order;
    • a tfSponsorCreatedAccount payment flag;
    • two read endpoints: getAccountSponsorships and getAccountSponsorshipMovements.
  • Batch v1.1 signing: the dry-run's batchSigningData gains a required signers[], with one signing payload per batch signer. The old signingPayload/signingPayloadHash are deprecated ("not signable under Batch v1.1"), and there's a new InvalidBatchSignature hint.

All additions are optional fields or new types, so nothing the SDK builds today changes. The new APIs are reachable through api.call / api.propose and are version-gated as devbox-only.

Context of Change

Devbox builds are redeployed without a version bump, so the vendored spec had fallen behind the live instance. Batch v1.1 matters most: the upcoming Batch support must sign per signers[] entry.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

  • Fetched with npm run fetch:custody-instance-spec -- --channel devbox --build cmpt, then npm run typegen. Re-running typegen gives no drift.
  • Typecheck, lint, format, unit tests, script tests, and build all pass. The changes are generated types only.
  • Not exercised live: the new APIs exist only on the devbox, so they'll be tested with the sponsorship and Batch work.

@pdp2121
pdp2121 merged commit 76e6902 into main Nov 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant