Repository navigation
chore: refresh the cMPT devbox Custody spec - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Re-vendors the cMPT devbox's public and internal specs and regenerates the types. The devbox still reports
1.36.2, but it has been redeployed with new APIs:SponsorshipSetAsSponsor/SponsorshipSetAsSponseeXRPL operations;sponsorshipblock on any XRPL transaction order;tfSponsorCreatedAccountpayment flag;getAccountSponsorshipsandgetAccountSponsorshipMovements.batchSigningDatagains a requiredsigners[], with one signing payload per batch signer. The oldsigningPayload/signingPayloadHashare deprecated ("not signable under Batch v1.1"), and there's a newInvalidBatchSignaturehint.All additions are optional fields or new types, so nothing the SDK builds today changes. The new APIs are reachable through
api.call/api.proposeand are version-gated as devbox-only.Context of Change
Devbox builds are redeployed without a version bump, so the vendored spec had fallen behind the live instance. Batch v1.1 matters most: the upcoming Batch support must sign per
signers[]entry.Type of Change
Test Plan
npm run fetch:custody-instance-spec -- --channel devbox --build cmpt, thennpm run typegen. Re-running typegen gives no drift.