fix: bound dedupe cache with MAX_INFLIGHT=200 and 30s TTL#835
Merged
Conversation
- Add MAX_INFLIGHT=200 constant; reject new entries when the cache is full - Add DEDUPE_TTL_MS=30_000; auto-evict stale entries via setTimeout - Clear TTL timer on normal completion/error - Update cancelDedupe and clearDedupeCache to clean up pending timers - Add comprehensive test suite covering size limit, TTL eviction, timer cleanup, and backward-compatible dedup behavior Close rinafcode#734
|
@EmeditWeb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bounded the in-flight deduplication cache to prevent unbounded memory growth when requests hang indefinitely.
Changes
src/lib/api/dedupe.tsMAX_INFLIGHT = 200— rejects new dedupe entries when the map reaches 200 entriesDEDUPE_TTL_MS = 30_000— each entry gets a 30-second timeout that rejects the promise and removes the entry automaticallycancelDedupeandclearDedupeCacheto also clean up pending timerssrc/lib/api/__tests__/dedupe.test.ts(new)Acceptance Criteria
Closes #734