Skip to content

feat: make maxRetries configurable via hook options and add tests#828

Open
Opulencechuks wants to merge 1 commit into
rinafcode:mainfrom
Opulencechuks:feature/configurable-max-retries
Open

feat: make maxRetries configurable via hook options and add tests#828
Opulencechuks wants to merge 1 commit into
rinafcode:mainfrom
Opulencechuks:feature/configurable-max-retries

Conversation

@Opulencechuks

Copy link
Copy Markdown

Description

Implemented a configurable maxRetries option for the useVideoPlayer hook, allowing callers to specify the number of retry attempts (default is 3). Updated the hook signature, added TypeScript typings, removed the hard‑coded constant, and introduced a new test to verify the option’s behavior.

Related Issue

Closes #775

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No console errors
  • Uses Lucide icons consistently
  • Responsive design implemented
  • Starknet best practices followed

@drips-wave

drips-wave Bot commented Jun 29, 2026

Copy link
Copy Markdown

@Opulencechuks Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Great job so far

There’s just one blocker — the workflow is failing. Could you take a look and fix it so all checks pass?

Happy to review again once that’s done.
You can pull from the main first before pushing. The workflow should pass

1 similar comment
@RUKAYAT-CODER

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor] useVideoPlayer hardcodes maxRetries = 3 with no external configuration

2 participants