Skip to content

Google and GitHub OAuth buttons are non-functional — missing click ha…#818

Open
heymide wants to merge 1 commit into
rinafcode:mainfrom
heymide:google-oauth
Open

Google and GitHub OAuth buttons are non-functional — missing click ha…#818
heymide wants to merge 1 commit into
rinafcode:mainfrom
heymide:google-oauth

Conversation

@heymide

@heymide heymide commented Jun 28, 2026

Copy link
Copy Markdown

Close: #758

Description

Summary of Changes

We've added full Google and GitHub OAuth login/signup support following the existing Discord OAuth pattern:

  1. Created OAuth library files :

    • src/lib/google/oauth.ts - Handles Google OAuth URL generation, token exchange, user info fetching
    • src/lib/github/oauth.ts - Handles GitHub OAuth URL generation, token exchange, user info fetching
  2. Created API routes :

    • src/app/api/auth/google/route.ts - Initiates Google OAuth flow
    • src/app/api/auth/google/callback/route.ts - Handles Google OAuth callback
    • src/app/api/auth/github/route.ts - Initiates GitHub OAuth flow
    • src/app/api/auth/github/callback/route.ts - Handles GitHub OAuth callback
  3. Created UI components :

    • src/app/components/auth/GoogleButton.tsx - Reusable Google login button
    • src/app/components/auth/GitHubButton.tsx - Reusable GitHub login button
  4. Updated login/signup pages :

    • Added handleGoogleLogin , handleGitHubLogin handlers in login/page.tsx
    • Added handleGoogleSignup , handleGitHubSignup handlers in signup/page.tsx
    • Replaced static buttons with new GoogleButton/GitHubButton components
  5. Updated configuration :

    • Added Google and GitHub OAuth environment variables to .env.example
      All implementations mirror the existing Discord OAuth flow for consistency in error handling, security (state parameter for CSRF protection), and rate limiting.

Related Issue

Closes #758

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No console errors
  • Uses Lucide icons consistently
  • Responsive design implemented
  • Starknet best practices followed

@drips-wave

drips-wave Bot commented Jun 28, 2026

Copy link
Copy Markdown

@heymide Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@heymide

heymide commented Jun 28, 2026

Copy link
Copy Markdown
Author

Done, Close: #818

@RUKAYAT-CODER

RUKAYAT-CODER commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Great job so far

There’s just one blocker — the workflow is failing. Could you take a look and fix it so all checks pass?

Happy to review again once that’s done.
You can pull from the main first before pushing. The workflow should pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Google and GitHub OAuth buttons are non-functional — missing click handlers

2 participants