feat: add configurable RS256 asymmetric JWT signing support#933
Open
aliyuHabibu wants to merge 2 commits into
Open
feat: add configurable RS256 asymmetric JWT signing support#933aliyuHabibu wants to merge 2 commits into
aliyuHabibu wants to merge 2 commits into
Conversation
- Create jwt-config.factory.ts to load PEM keys from env vars or file paths - Update AuthModule to use JwtModule.registerAsync with dynamic algorithm detection - Update JwtStrategy to use secretOrKeyProvider for runtime key resolution - Update AuthService to sign with private key when RS256 is configured - HS256 fallback when PEM keys are not set (backward compatible) - Add JWT_PRIVATE_KEY and JWT_PUBLIC_KEY env vars with Joi validation - Document RS256 key generation and rotation in docs/authentication.md
|
@aliyuHabibu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Great work on this PR |
Author
|
@RUKAYAT-CODER Review again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #836