feat: add file size limits and magic bytes validation for CDN upload#921
Open
frankosakwe wants to merge 8 commits into
Open
feat: add file size limits and magic bytes validation for CDN upload#921frankosakwe wants to merge 8 commits into
frankosakwe wants to merge 8 commits into
Conversation
- Add file-type package dependency for magic bytes detection - Create CDN controller with upload endpoint - Implement file size validation (10MB images, 500MB videos) - Implement magic bytes validation to detect MIME type mismatches - Update media-processing.worker.ts with validation - Add comprehensive unit tests for size limits and MIME validation - Update file size limits to match specifications Security improvements: - Reject files exceeding size limits with 413 error - Reject files with wrong magic bytes with 415 error - Prevent PHP scripts disguised as video files - Validate declared MIME type against actual file content
|
@frankosakwe Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Great work on this PR |
- Remove trailing spaces in test files - Remove unused import in cdn.controller.ts - Fix parameter formatting in uploadContent method - Break long line in getMaxSizeForType for readability - Format imports in media-processing.worker.spec.ts
Author
|
done you can pls check |
added 6 commits
June 29, 2026 13:47
- Use local UploadedFile interface instead of Express.Multer.File - Add type assertion for MIME type includes check - Update test file to use UploadedFile interface
Author
|
can you help me check pls |
Contributor
|
There is conflict |
Author
this is what it shows me when i try to resolve the issue
|
Contributor
|
You cant resolve with Github because it is too complex, use your editor to resolve the conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security improvements:
closes #850