Skip to content

Fix direct punctuation commits with marked text - #1172

Closed
shangyingbin wants to merge 1 commit into
rime:masterfrom
shangyingbin:fix-direct-punctuation-marked-text
Closed

Fix direct punctuation commits with marked text#1172
shangyingbin wants to merge 1 commit into
rime:masterfrom
shangyingbin:fix-direct-punctuation-marked-text

Conversation

@shangyingbin

Copy link
Copy Markdown

Summary

  • Add a compatibility option for direct punctuation commits.
  • Pre-mark direct punctuation keys before processing them on the next run loop so clients that require a marked-text phase can accept the committed full-width punctuation.
  • Enable the compatibility path by default in squirrel.yaml.

Testing

  • Built and packaged locally with make clean-package package ARCHS="arm64 x86_64" BUILD_UNIVERSAL=1.
  • Installed the generated package locally and verified the installed binary matches the build output.
  • Tested direct punctuation input in WeChat, DingTalk, Notes, macOS Terminal, and VSCode integrated terminal for one day without finding regressions.

@lotem

lotem commented Aug 13, 2026

Copy link
Copy Markdown
Member

看着有點兒像 #1171

不太看好。
能否說明解決什麼問題,爲什麼要這麼複雜?

在 Terminal.app 裏上屏標點我試着沒問題的。

@shangyingbin

Copy link
Copy Markdown
Author

系统自带的terminal app中没有问题,但是在vscode中开启的终端,无法输入中文符号。

@shangyingbin

Copy link
Copy Markdown
Author

如果认为不应合入,就丢弃吧。我本地打一个包自己用就好

@lotem

lotem commented Aug 14, 2026

Copy link
Copy Markdown
Member

需求了解了。考慮收錄 PR #1171 ——他有兩點優勢:

  1. 限定延遲提交機制生效的客戶端應用;
  2. 不根據字符種類做經驗判斷,直接提交的字符可由方案任意設定,不限於標點符號。

@lotem lotem closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants