-
Notifications
You must be signed in to change notification settings - Fork 0
Create Remove-Duplicates-from-Sorted-List.md #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
riku359
wants to merge
2
commits into
main
Choose a base branch
from
Remove-Duplicates-from-Sorted-List
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
Remove-Duplicates-from-Sorted-List/Remove-Duplicates-from-Sorted-List.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| # Step1 | ||
| current_nodeを走査する方針は思いついたが、 | ||
| 次の要素を除去するロジックの書き方がわからない。 | ||
| ```python | ||
| # Definition for singly-linked list. | ||
| # class ListNode: | ||
| # def __init__(self, val=0, next=None): | ||
| # self.val = val | ||
| # self.next = next | ||
| class Solution: | ||
| def deleteDuplicates(self, head: Optional[ListNode]) -> Optional[ListNode]: | ||
| current_node = head | ||
| while current_node is not None: | ||
| if current_node.value == current_node.next.value: | ||
| # 次の要素を除去 | ||
| return head | ||
| ``` | ||
|
|
||
| geminiにヒントを貰う。 | ||
|
|
||
|
|
||
| 次の要素の除去 = nodeの参照先を次の次にする。とのこと | ||
| ```python | ||
| current_node.next = current_node.next.next | ||
| ``` | ||
|
|
||
| 修正するもまだエラーが出る | ||
| ```python | ||
| class Solution: | ||
| def deleteDuplicates(self, head: Optional[ListNode]) -> Optional[ListNode]: | ||
| current_node = head | ||
| while current_node is not None: | ||
| if current_node.val == current_node.next.val: | ||
| # 次の次のノードを参照 | ||
| current_node.next = current_node.next.next | ||
| else: | ||
| current_node = current_node.next | ||
| return head | ||
| ``` | ||
|
|
||
| ``` | ||
| AttributeError: 'NoneType' object has no attribute 'val' | ||
| ^^^^^^^^^^^^^^^^^^^^^ | ||
| if current_node.val == current_node.next.val: | ||
| Line 10 in deleteDuplicates (Solution.py) | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| ret = Solution().deleteDuplicates(param_1) | ||
| Line 43 in _driver (Solution.py) | ||
| _driver() | ||
| Line 58 in <module> (Solution.py) | ||
| ``` | ||
|
|
||
| current_nodeがNoneTypeになっているようだ。 | ||
|
|
||
| geminiに再度確認したところ、current_node.nextがnot Noneであることもwhile loopの条件に加える必要とのこと。 | ||
|
|
||
| ```python | ||
| class Solution: | ||
| def deleteDuplicates(self, head: Optional[ListNode]) -> Optional[ListNode]: | ||
| current_node = head | ||
| while current_node is not None and current_node.next is not None: | ||
| if current_node.val == current_node.next.val: | ||
| # 次の次のノードを参照 | ||
| current_node.next = current_node.next.next | ||
| else: | ||
| current_node = current_node.next | ||
| return head | ||
| ``` | ||
| パスできた。 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current という単語には、あまり情報がないように思います。外しても良いと思います。