Repository navigation
Fix sample Crashlytics initialization order - #63
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reassessment correction: the current target base 3fd7822 already calls FirebaseApp.configure() immediately before constructing the Crashlytics reporter in sample/NSExceptionKtSample/AppDelegate.swift. The original claim that these two calls were reversed is incorrect. This patch only moves that already-correct block before Bugsnag initialization; no supported-use failure requiring that reordering has been established. Withdrawing this report/patch on that basis, without claiming all reporter initialization behavior is verified.
Original report (superseded):
Closes #61.\n\nConfigure Firebase before constructing the default Crashlytics reporter in the sample AppDelegate. This aligns the sample with the setup order in the library README and Firebase documentation.\n\nValidation:
git diff --checkpassed. The sample requires Xcode/iOS tooling to build, which is unavailable in this Windows environment.