Skip to content

Fix sample Crashlytics initialization order - #63

Closed
dajiaohuang wants to merge 1 commit into
rickclephas:masterfrom
dajiaohuang:fix/sample-firebase-init
Closed

dajiaohuang wants to merge 1 commit into
rickclephas:masterfrom
dajiaohuang:fix/sample-firebase-init

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Oct 4, 2026 •

Copy link
Copy Markdown

Reassessment correction: the current target base 3fd7822 already calls FirebaseApp.configure() immediately before constructing the Crashlytics reporter in sample/NSExceptionKtSample/AppDelegate.swift. The original claim that these two calls were reversed is incorrect. This patch only moves that already-correct block before Bugsnag initialization; no supported-use failure requiring that reordering has been established. Withdrawing this report/patch on that basis, without claiming all reporter initialization behavior is verified.


Original report (superseded):

Closes #61.\n\nConfigure Firebase before constructing the default Crashlytics reporter in the sample AppDelegate. This aligns the sample with the setup order in the library README and Firebase documentation.\n\nValidation: git diff --check passed. The sample requires Xcode/iOS tooling to build, which is unavailable in this Windows environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure Firebase before constructing the sample Crashlytics reporter

1 participant