Skip to content

docs: add CLAUDE.md with project guidance#1047

Open
lihongyan1 wants to merge 1 commit intorhobs:mainfrom
lihongyan1:docs-add-claude-md
Open

docs: add CLAUDE.md with project guidance#1047
lihongyan1 wants to merge 1 commit intorhobs:mainfrom
lihongyan1:docs-add-claude-md

Conversation

@lihongyan1
Copy link
Copy Markdown
Contributor

Add comprehensive project documentation for Claude Code including development setup, architecture overview, and common workflows.

Pulled this file before use claude, will save tokens

Add comprehensive project documentation for Claude Code including
development setup, architecture overview, and common workflows.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci openshift-ci bot requested review from jgbernalp and marioferh April 1, 2026 08:11
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lihongyan1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 1, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

📝 Walkthrough

Walkthrough

A new CLAUDE.md documentation file is added to the repository root, providing Claude Code guidance for the Observability Operator project including setup instructions, architecture overview, development commands, local workflow, and contribution processes.

Changes

Cohort / File(s) Summary
Documentation
CLAUDE.md
New documentation file with Claude Code guidance covering project overview (Kubernetes operator, controller-runtime, Prometheus Operator fork), development setup, Make/test/lint commands, local operator workflow, architecture details, code generation, testing, and contribution guidelines.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and accurately describes the main change: adding a new CLAUDE.md documentation file with project guidance.
Description check ✅ Passed The description is related to the changeset, explaining that comprehensive project documentation is being added for Claude Code including setup, architecture, and workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
CLAUDE.md (1)

66-76: Clarify that TLS verification flags are for local development only.

The workflow uses --tls-verify=false and --skip-tls flags, which disable certificate verification. While appropriate for local Kind clusters, consider adding a note that these flags should never be used in production environments to prevent security misconfigurations if developers copy these commands.

📝 Suggested clarification
 # Build and push operator and bundle to local registry
+# Note: --tls-verify=false and --skip-tls are for local development only
 make operator-image bundle-image operator-push bundle-push \
     IMG_BASE="local-registry:30000/observability-operator" \
     VERSION=0.0.0-dev \
     PUSH_OPTIONS=--tls-verify=false
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CLAUDE.md` around lines 66 - 76, Add a short, explicit warning next to the
build/push and run bundle commands clarifying that the flags
PUSH_OPTIONS=--tls-verify=false and the operator-sdk --skip-tls option disable
TLS/certificate verification and are intended for local development (e.g., Kind)
only; update the CLAUDE.md section containing the make operator-image ...
PUSH_OPTIONS and the ./tmp/bin/operator-sdk run bundle ... --skip-tls snippet to
instruct developers to remove these flags or use proper TLS certificates in any
non-local/production environment and to follow your cluster's certificate best
practices.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@CLAUDE.md`:
- Around line 66-76: Add a short, explicit warning next to the build/push and
run bundle commands clarifying that the flags PUSH_OPTIONS=--tls-verify=false
and the operator-sdk --skip-tls option disable TLS/certificate verification and
are intended for local development (e.g., Kind) only; update the CLAUDE.md
section containing the make operator-image ... PUSH_OPTIONS and the
./tmp/bin/operator-sdk run bundle ... --skip-tls snippet to instruct developers
to remove these flags or use proper TLS certificates in any non-local/production
environment and to follow your cluster's certificate best practices.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5a81253b-1e31-43f5-a9ed-26b6c9144093

📥 Commits

Reviewing files that changed from the base of the PR and between cf377a3 and d797062.

📒 Files selected for processing (1)
  • CLAUDE.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant