Integrate horologium - #304
Open
rhannequin wants to merge 7 commits into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Standard precision breaks the documented exactness guarantee for TAI conversions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Integrates horologium for TAI/TDB conversion while retaining Astronoby’s TT and UT1 handling.
Changes:
- Adds accurate TDB conversion and Rational outputs.
- Updates precession to use TT.
- Raises
iersto 0.2 and updates documentation.
File summaries
| File | Description |
|---|---|
UPGRADING.md |
Documents migration and precision changes. |
spec/astronoby/instant_spec.rb |
Tests TDB conversion and output type. |
lib/astronoby/precession.rb |
Evaluates precession using TT. |
lib/astronoby/instant.rb |
Delegates TAI/TDB conversions to horologium. |
lib/astronoby/constants.rb |
Removes the local TAI–TT offset. |
Gemfile.lock |
Locks new dependency versions. |
docs/instant.md |
Updates time-scale documentation. |
docs/glossary.md |
Adds TAI and TDB definitions. |
CHANGELOG.md |
Records user-visible changes. |
astronoby.gemspec |
Adds horologium and raises iers. |
Review details
- Files reviewed: 9/10 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rhannequin
force-pushed
the
integrate-horologium
branch
from
September 4, 2026 21:01
55d68f0 to
bcfed9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time scale conversions that hold by definition or by model belong in
horologiumrather than in Astronoby, so TAI and TDB are now read from it. UT1 stays it: it follows the actual rotation of the Earth and rests on observed ΔT, which is not whathorologiumis for.Instantkeeps its Terrestrial Time Julian Date as before and builds the horologium instant on the first reading that needs it.The paths that only want TT never touch it, so the rise/transit/set, twilight, moon phase, eclipse and position workloads stay where they were.
tdbused to return Terrestrial Time unchanged, documented in the source as an approximation. It now returns real TDB from the Fairhead and Bretagnon series ERFA uses. Precession is evaluated in TT, correction.horologiumrequiresiers0.2, so the minimumiersversion is raised from 0.1 to 0.2.