fix(http_proxy): preserve upstream redirects for SSO flows - #273
Merged
Conversation
- preserve existing keepalive behavior for current callers - record the CC proxy redirect passthrough fix
dengxiayehu
force-pushed
the
fix/auth
branch
from
September 6, 2026 01:38
afd97d8 to
fb49201
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The HTTP proxy client followed upstream redirects automatically. As a result, callers could not receive
the original
3xxresponse andLocationheader required to complete SSO handoff flows.Regular HTTP redirects were followed by the proxy itself, while redirects using a custom URI scheme
could fail before reaching the client.
Fix
existing timeout, connection pool, and TCP keepalive behavior.
Locationheaders unchanged so the calling client can handlethe SSO redirect.
verification that the proxy does not request the redirect destination.