feat(react-email): filter compatibility warnings by email client#3547
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 3b5af2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
felipefreitag
force-pushed
the
feat/clients-compat-flag
branch
from
854a300 to
464f488
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 13 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The changes add a controlled filter for compatibility warnings with proper validation, fallback to defaults when invalid, and clear UI indicators, all within an isolated subsystem and without affecting core business logic, security, or data integrity.
Re-trigger cubic
gabrielmfern
approved these changes
May 27, 2026
felipefreitag
force-pushed
the
feat/clients-compat-flag
branch
from
464f488 to
4eb0fe5
Compare
Adds --clients to email dev and reads COMPATIBILITY_EMAIL_CLIENTS from the
environment so teams that only target a subset of clients can quiet warnings
for the rest. The CLI flag wins over the env var; an empty or fully-invalid
list falls back to the defaults so warnings can't be silently switched off.
The empty-state copy on the Compatibility tab now names the active client
list ("Template should render properly in Gmail") instead of claiming
"everywhere," so the filter scope isn't misrepresented when there are no
issues.
Builds on #2797 by @ReemX with the cubic-flagged regressions fixed: the
port-retry path now preserves the flag, undefined no longer clobbers a
user-set env var, and invalid env values fall back to the defaults instead
of suppressing all checks.
Co-authored-by: ReemX <reemasaf44@gmail.com>
Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
felipefreitag
force-pushed
the
feat/clients-compat-flag
branch
from
4eb0fe5 to
3b5af2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds --clients to email dev and reads COMPATIBILITY_EMAIL_CLIENTS from the environment so teams that only target a subset of clients can quiet warnings for the rest. The CLI flag wins over the env var; an empty or fully-invalid list falls back to the defaults so warnings can't be silently switched off. The Compatibility tab shows the active client list above the results so the filter is never invisible.
Builds on #2797 by @ReemX with the cubic-flagged regressions fixed: the port-retry path now preserves the flag, undefined no longer clobbers a user-set env var, and invalid env values fall back to the defaults instead of suppressing all checks. This PR supersedes that one.
Added a list of the current clients to the Compatibility tab so the user can know what the template is verified against:
Summary by cubic
Add a clients filter for compatibility checks so teams only see warnings for the email clients they target. Adds
email dev --clientsandCOMPATIBILITY_EMAIL_CLIENTS, and updates the Compatibility tab and success copy to name the active clients.New Features
react-emailCLI:--clients <comma-separated>controls which clients trigger warnings. Validates names; errors on unknown or empty lists. OverridesCOMPATIBILITY_EMAIL_CLIENTS. Defaults:gmail,apple-mail,outlook,yahoo. Example:email dev --clients outlook,apple-mail.COMPATIBILITY_EMAIL_CLIENTS; invalid or empty values fall back to defaults.Bug Fixes
COMPATIBILITY_EMAIL_CLIENTSwith undefined.Written for commit 3b5af2f. Summary will update on new commits. Review in cubic