Fix fatal crash on duplicate prompt context metrics - #751
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a fatal crash (
EXC_BREAKPOINT: Duplicate values for key) occurring whenPromptContextEntryMetricsSnapshot.initattempts to construct dictionaries (metricsByFileIDandmetricsByStandardizedFullPath) usingDictionary(uniqueKeysWithValues:).The root cause is that the
metricsarray passed to the initializer can containPromptContextEntryMetricitems with identicalfileIDs orstandardizedFullPaths, especially when the same file is included multiple times in the prompt context.uniqueKeysWithValuesdoes not handle duplicate keys and crashes.The fix replaces
Dictionary(uniqueKeysWithValues:)withDictionary(_:uniquingKeysWith: { first, _ in first })for both dictionary constructions. This ensures that if duplicate keys are encountered, the first value for that key is retained, preventing the crash and allowing the system to gracefully handle such scenarios.Fixes REPOPROMPT-GJ