fix: lazy cache initialization to support completion commands with invalid HOME#744
Open
replicated-software-factory[bot] wants to merge 2 commits into
Open
fix: lazy cache initialization to support completion commands with invalid HOME#744replicated-software-factory[bot] wants to merge 2 commits into
replicated-software-factory[bot] wants to merge 2 commits into
Conversation
…valid HOME The CLI was calling InitCache() in the init() function, which would fail when HOME was set to an invalid path (e.g., during Nix builds). This caused commands like 'replicated completion zsh' to panic even though they don't need the cache at all. This change makes cache initialization lazy - it only happens when the cache is actually needed. This allows completion commands to work in environments where HOME is not writable. Fixes #535
divolgin
reviewed
May 21, 2026
Per review feedback, the lazy-init singleton state (once/instance/err) and GetInstance helper now live in the cache package itself, removing the ambiguity between local cache variables, the former global cacheInstance, and the replicatedcache import alias. Call sites use cache.GetInstance(); tests use cache.ResetForTesting(). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
divolgin
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #535
The CLI was calling InitCache() in the init() function, which would fail when HOME was set to an invalid path (e.g., during Nix builds). This caused commands like
replicated completion zshto panic even though they don't need the cache at all.Changes
Testing
HOME=/invalid replicated completion zshnow works without panicImpact
This allows Nix builds (and other environments where HOME is not writable) to generate shell completions without workarounds.