Skip to content

Fix e2e flakes from pretty-print line drift on unmapped sources - #10655

Merged
Domiii merged 3 commits into
mainfrom
dominik/ci-2448-pp-line-candidates
Aug 1, 2026
Merged

Fix e2e flakes from pretty-print line drift on unmapped sources#10655
Domiii merged 3 commits into
mainfrom
dominik/ci-2448-pp-line-candidates

Conversation

@Domiii

@Domiii Domiii commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Fix e2e PpEngineDrift line assertions

G1: waitForPaused — accept candidate lines

  • waitForPaused / warpToMessage / seekToConsoleMessage now take number | number[].
  • Assertion is membership in the candidate set.

G2: object_preview-04

  • Drop frame-line assertions on warp / after toggle.
  • Scopes already establish the correct pause.
  • CI showed the pause line as 15, 19, or 4 depending on original vs generated/pp.

G3: logpoints-07

  • After findLineWithHits([20, 21]), rewindToLine so autocomplete runs against the generated/pp hit scope.

G4: typecheck

Accept candidate pause lines and rewind to the generated hit line before logpoint autocomplete.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
devtools Ready Ready Preview Aug 1, 2026 4:31pm

Request Review

@Domiii Domiii self-assigned this Aug 1, 2026
@Domiii
Domiii requested a review from Andarist August 1, 2026 16:11
@Domiii
Domiii requested a review from markerikson August 1, 2026 16:12
Co-authored-by: Cursor <cursoragent@cursor.com>
@replay-io

replay-io Bot commented Aug 1, 2026

Copy link
Copy Markdown

E2E Tests

Status Complete ↗︎
Commit 45f7b07
Results
4 Failed
  • inspector-computed-02: Complex computed styles can be viewed (Replay 1, Replay 2, Replay 3, Replay 4, Replay 5, Replay 6, Replay 7, Replay 8)
  • jump-to-code-01: Test basic jumping functionality (Replay 1, Replay 2, Replay 3, Replay 4, Replay 5, Replay 6, Replay 7, Replay 8)
  • playwright-05: Test DOM node previews on user action step hover (Replay 1, Replay 2, Replay 3, Replay 4, Replay 5, Replay 6, Replay 7, Replay 8)
  • stepping-06: Test stepping in async frames and async call stacks (Replay 1, Replay 2, Replay 3, Replay 4, Replay 5, Replay 6, Replay 7, Replay 8)
  • ⚠️ 3 Flaky
  • authenticated/logpoints-01: Shared logpoints functionality (Replay 1, Replay 2, Replay 3, Replay 4, Replay 5, Replay 6, Replay 7)
  • cypress-04: Test Step buttons and menu item (Replay 1, Replay 2, Replay 3, Replay 4)
  • network-03: should sync and display the current time in relation to the network requests (Replay 1, Replay 2)
  • 94 Passed
  • async-stack: should detect async stacks outside the focus window
  • authenticated/comments-01: Test add, edit, and delete comment functionality
  • authenticated/comments-02: Test shared comments and replies (Replay 1, Replay 2)
  • authenticated/comments-03: Comment previews
  • authenticated/passport-01: Time travel
  • authenticated/passport-02: Infrared inspection
  • authenticated/passport-03: Swiss army knife
  • authenticated/passport-04: Multiplayer
  • console_async: support console evaluations in async frames
  • console_dock: Should show the correct docking behavior for recordings with video
  • console_errors: Test that errors and warnings from various sources are shown in the console
  • console_eval: support console evaluations
  • console_warp-01: should support warping to console messages
  • console_warp-02: support pausing, warping, stepping and evaluating console messages
  • console-expressions-01: should cache input eager eval and terminal expressions per instance
  • cypress-01: Basic Test Suites panel functionality
  • cypress-02: Test Step timeline behavior
  • cypress-03: Test Step interactions (Replay 1, Replay 2)
  • cypress-05: Test DOM node preview on user action step hover (Replay 1, Replay 2)
  • deleted-recording: Show error message for deleted recording (Replay 1, Replay 2)
  • elements-search: Element panel should support basic and advanced search modes (Replay 1, Replay 2)
  • fe-1875 :: verify that steps go to the right point in time (Replay 1, Replay 2)
  • file-search-01: should search files (Replay 1, Replay 2)
  • focus_mode-01: should filter messages as regions based on the active focus mode (Replay 1, Replay 2)
  • highlighter: element highlighter works everywhere (Replay 1, Replay 2)
  • inspector-computed-01: Basic computed styles can be viewed (Replay 1, Replay 2)
  • inspector-elements-01: Basic DOM tree node display (Replay 1, Replay 2)
  • inspector-elements-02_node-picker: element picker and iframe behavior (Replay 1, Replay 2)
  • inspector-elements-03: Nested node picker and selection behavior (Replay 1, Replay 2)
  • inspector-elements-04: Keyboard shortcuts should select the right DOM nodes (Replay 1, Replay 2)
  • inspector-elements-05_search: element picker and iframe behavior (Replay 1, Replay 2)
  • inspector-rules-01: Basic CSS rules should be viewed (Replay 1, Replay 2)
  • inspector-rules-03: Shorthand CSS rules should be viewed (Replay 1, Replay 2)
  • jump-to-code-02: Redux J2C functionality (Replay 1, Replay 2)
  • logpoints-01: log-points appear in the correct order and allow time warping
  • logpoints-02: conditional log-points
  • logpoints-03: should display event properties in the console
  • logpoints-04: should display exceptions in the console
  • logpoints-05: should auto-complete based on log point location
  • logpoints-06: should be temporarily disabled
  • logpoints-07: should use the correct scope in auto-complete
  • logpoints-08: should support jumping directly to a hit point via the capsule input
  • logpoints-09: should support pending edits
  • logpoints-10: too-many-points-to-find UX
  • logpoints-11: too-many-points-to-run-analysis UX
  • logpoints-12: should auto save when removing conditions
  • logpoints-13: Test log point in a sourcemapped file
  • network-01: should filter requests by type and text
  • network-02: should show details for the selected request
  • node_console_dock: Should show the correct docking behavior for recordings without video
  • node_console-01: Basic node console behavior
  • node_console-02: uncaught exceptions should show up
  • node_control_flow: catch, finally, generators, and async/await
  • node_logpoint-01: Basic node logpoints
  • node_object_preview: Showing console objects in node
  • node_quick_open_modal-01: Test basic searching functionality
  • node_spawn: Basic subprocess spawning
  • node_stepping-01: Test stepping in async frames and async call stacks
  • node_worker-01: make sure node workers don't cause crashes
  • object_preview-01: expressions in the console after time warping
  • object_preview-02: should allow objects in scope to be inspected
  • object_preview-03: Test previews when switching between frames and stepping
  • object_preview-04: Test scope mapping and switching between generated/original sources
  • object_preview-05: Should support logging objects as values
  • object_preview-06: HTML elements
  • object_preview-07: inspect objects in the console while paused somewhere else
  • object_preview-08: should render ellipsis for collapsed objects with truncated properties
  • playwright-01: Basic Test Suites panel functionality
  • playwright-02: Test Step timeline behavior
  • playwright-03: Test Step interactions
  • playwright-04: Test Step buttons and menu item (Replay 1, Replay 2)
  • react_devtools-01: Basic RDT behavior (Replay 1, Replay 2)
  • react_devtools-02: RDT integrations (Chromium) (Replay 1, Replay 2)
  • react_devtools-03: process and display multiple React versions in page (Replay 1, Replay 2)
  • react_devtools-04: Component selection is maintained when seeking to a new point (Replay 1, Replay 2)
  • redux_devtools: Test Redux DevTools. (Replay 1, Replay 2)
  • repaint-01: repaints the screen screen when stepping over code that modifies the DOM (Replay 1, Replay 2)
  • repaint-02: repaints on hover
  • repaint-03: repaints on seek
  • repaint-04: prefers nearest (<=) paint when seeking between paints
  • repaint-05: prefers current time if pause creation failed outside of the focus window
  • repaint-06: repaints the screen screen when stepping over code that modifies the DOM
  • resizable-panels-01: Left side Toolbar and Video should be collapsible
  • restart-session: restart debugging session
  • scopes_rerender: Test that scopes are rerendered
  • session-destroyed: errors caused by session failure should bubble to the root
  • source-line-highlights: Test source line highlighting (Replay 1, Replay 2)
  • sourcemap_stacktrace: Test that stacktraces are sourcemapped (Replay 1, Replay 2)
  • stacking: Element highlighter selects the correct element when they overlap (Replay 1, Replay 2)
  • stepping-01: Test basic step-over/back functionality (Replay 1, Replay 2)
  • stepping-02: Test fixes for some simple stepping bugs (Replay 1, Replay 2)
  • stepping-04: Test stepping in a frame other than the top frame (Replay 1, Replay 2)
  • stepping-05: Test stepping in pretty-printed code (Replay 1, Replay 2)
  • stepping-07: Test quick stepping using the keyboard (Replay 1, Replay 2)
  • Pause line drifts across original/generated/pp; scopes already pin the pause.
    
    Co-authored-by: Cursor <cursoragent@cursor.com>
    @Domiii
    Domiii merged commit 527d9a3 into main Aug 1, 2026
    30 of 38 checks passed
    @Domiii
    Domiii deleted the dominik/ci-2448-pp-line-candidates branch August 1, 2026 16:53
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants