Repository navigation
[188c8d18] Fix cadence review counted fields and failing CI on PR 1455 - #1508
Merged
roboco-app[bot] merged 2 commits intoNov 4, 2026
Conversation
roboco-app
Bot
merged commit Nov 4, 2026
70b2a11
into
feature/backend/55eb48c9--89318757
7 of 8 checks passed
roboco-app
Bot
deleted the
feature/backend/55eb48c9--89318757--188c8d18
branch
November 4, 2026 05:51
|
Thanks for opening your first pull request on RoboCo! Quick checklist before review (most of these are enforced by CI, but worth a glance):
See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow. Welcome aboard — a maintainer will review shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-2 PR-gate findings on PR #1455 (branch feature/backend/55eb48c9--89318757). Two fixes, same files, one dev.
F-23e0a4b9 (minor) at roboco/services/board_program_cadence_policy.py:110: the CEO review row shows the all-cycle items_approved but not items_approved_counted or cycles_counted, which decide_slowdown actually uses. With deleted-task cycles the row can show approvals while cost_per_approved is null (infinite). Fix: add cycles_counted and items_approved_counted to ProgramCadenceReview (roboco/models/board_program_cadence_review.py) and fill them from the metric (roboco/services/board_program_cadence.py, roboco/models/board_program_cadence.py) in review(). Assert both in tests/unit/services/test_board_program_cadence_policy.py, including a deleted-task cycle case.
F-af7e364f (blocker): CI check 'ci' is failing on PR #1455 head 89ce8b2. make gate passes locally, so the failure is probably in the pytest stage (the new real-Postgres tests in tests/unit/services/test_board_program_cadence.py and test_board_program_cadence_policy.py), the coverage floor, or a later make quality stage. Open the failing ci run, find the failing step, reproduce it locally with make test / make quality, fix it, and push. Keep logic in roboco/services, models in roboco/models, and do not add lint suppressions.