Skip to content

[188c8d18] Fix cadence review counted fields and failing CI on PR 1455 - #1508

Merged
roboco-app[bot] merged 2 commits into
feature/backend/55eb48c9--89318757from
feature/backend/55eb48c9--89318757--188c8d18
Nov 4, 2026
Merged

roboco-app[bot] merged 2 commits into
feature/backend/55eb48c9--89318757from
feature/backend/55eb48c9--89318757--188c8d18

Conversation

@roboco-app

@roboco-app roboco-app Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Round-2 PR-gate findings on PR #1455 (branch feature/backend/55eb48c9--89318757). Two fixes, same files, one dev.

F-23e0a4b9 (minor) at roboco/services/board_program_cadence_policy.py:110: the CEO review row shows the all-cycle items_approved but not items_approved_counted or cycles_counted, which decide_slowdown actually uses. With deleted-task cycles the row can show approvals while cost_per_approved is null (infinite). Fix: add cycles_counted and items_approved_counted to ProgramCadenceReview (roboco/models/board_program_cadence_review.py) and fill them from the metric (roboco/services/board_program_cadence.py, roboco/models/board_program_cadence.py) in review(). Assert both in tests/unit/services/test_board_program_cadence_policy.py, including a deleted-task cycle case.

F-af7e364f (blocker): CI check 'ci' is failing on PR #1455 head 89ce8b2. make gate passes locally, so the failure is probably in the pytest stage (the new real-Postgres tests in tests/unit/services/test_board_program_cadence.py and test_board_program_cadence_policy.py), the coverage floor, or a later make quality stage. Open the failing ci run, find the failing step, reproduce it locally with make test / make quality, fix it, and push. Keep logic in roboco/services, models in roboco/models, and do not add lint suppressions.

@roboco-app
roboco-app Bot merged commit 70b2a11 into feature/backend/55eb48c9--89318757 Nov 4, 2026
7 of 8 checks passed
@roboco-app
roboco-app Bot deleted the feature/backend/55eb48c9--89318757--188c8d18 branch November 4, 2026 05:51
@github-project-automation github-project-automation Bot moved this from Backlog to Done in RoboCo Kanban Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Thanks for opening your first pull request on RoboCo!

Quick checklist before review (most of these are enforced by CI, but worth a glance):

  • make quality — ruff format check, ruff check, mypy, pytest (≥80% coverage), and the rest of the gate
  • Panel changes pass pnpm lint and pnpm exec tsc --noEmit (run from panel/)
  • No # noqa / # type: ignore shortcuts; pre-existing violations in touched files are fixed
  • Added an entry under ## [Unreleased] in CHANGELOG.md
  • Signed the CLA (the bot will prompt you on this PR)
  • Signed your commits — master requires verified signatures (SSH signing setup)
  • Updated any affected docs under docs/

See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow.

Welcome aboard — a maintainer will review shortly.

@github-actions github-actions Bot added documentation Docs, README, CHANGELOG, governance files area: services Touches roboco/services/ (business logic, side effects) area: db Touches roboco/db/ or roboco/models/ tests Test suite changes labels Nov 4, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: db Touches roboco/db/ or roboco/models/ area: services Touches roboco/services/ (business logic, side effects) cell/backend documentation Docs, README, CHANGELOG, governance files tests Test suite changes to feature/backend/55eb48c9--89318757

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

0 participants