[roboco-app]

Summary

Removes the dead no_helpers_in_routers entry and its comment from .roboco/conventions.yml, and rewords the posture and closing "inherits BLOCK" comments so they refer only to no_helpers_in_routes / routes. The assembled diff touches only .roboco/conventions.yml; the no_helpers_in_routes entry is unchanged and stays at warn. The stray docs/conventions-routers-rule-removal.md was removed from the branch.

Why

Rule names are built as no_{kind}s_in_{leaf} (roboco/conventions/placement.py:78, roboco/conventions/scan.py:157). roboco-api has no routers/ directory and no module with a routers leaf, so the rule can never fire here.

Source of the 22 no_helpers_in_routers findings

The Sentinel hotspot ledger is SentinelEngine._conventions_hotspots (roboco/services/sentinel_engine.py:210-216, method at 201-217). It runs GROUP BY rule over project_convention_findings with no project_id filter. The 22 rows are therefore org-wide findings recorded for other projects that have a routers/ leaf (roboco/conventions/scan.py:50 puts routers in the route-module name set, so any project with a routers/ dir gets that rule derived), not roboco-api findings.

Verification

make gate passes; cited line ranges verified against the current tree.

[github-actions]

Thanks for opening your first pull request on RoboCo!

Quick checklist before review (most of these are enforced by CI, but worth a glance):

• make quality — ruff format check, ruff check, mypy, pytest (≥80% coverage), and the rest of the gate
• Panel changes pass pnpm lint and pnpm exec tsc --noEmit (run from panel/)
• No # noqa / # type: ignore shortcuts; pre-existing violations in touched files are fixed
• Added an entry under ## [Unreleased] in CHANGELOG.md
• Signed the CLA (the bot will prompt you on this PR)
• Signed your commits — master requires verified signatures (SSH signing setup)
• Updated any affected docs under docs/

See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow.

Welcome aboard — a maintainer will review shortly.

[roboco-app]

In-path PR-review gate — CHANGES REQUESTED 🔴

Reviewed by pr_reviewer (RoboCo PR reviewer). Posted by the project bot account; the gate verdict is authoritative in RoboCo.

[F-25187b18] docs/conventions-routers-rule-removal.md:1 (major) — The assembled diff touches only .roboco/conventions.yml. → The diff also adds a new 25-line file, docs/conventions-routers-rule-removal.md, at the docs/ root, outside every existing docs subtree. → Drop this file from the branch. Put the explanation in the PR body and dev notes, which is where the task asks for it.
[F-32d49da4] docs/conventions-routers-rule-removal.md:21 (major) — A definite statement of the data source behind the 22 findings. → The text says the findings come from 'another project's derived conventions or to stale ... ledger data' and says to 'treat the exact source as unconfirmed'. → State the source: the Sentinel hotspot ledger is SentinelEngine._conventions_hotspots, which runs GROUP BY rule over project_convention_findings for all projects with no project_id filter. The 22 rows are org-wide findings recorded for other projects that have a routers/ leaf, not roboco-api findings. Put this in the PR #1503 body and the dev notes.