Skip to content

[928b741c] Reproduce and fix red Python quality gate on PR #1373 - #1419

Merged
roboco-app[bot] merged 3 commits into
feature/backend/94ef769a--b2b4d1dcfrom
feature/backend/94ef769a--b2b4d1dc--928b741c
Nov 4, 2026
Merged

roboco-app[bot] merged 3 commits into
feature/backend/94ef769a--b2b4d1dcfrom
feature/backend/94ef769a--b2b4d1dc--928b741c

Conversation

@roboco-app

@roboco-app roboco-app Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

PR #1373 (cell branch feature/backend/94ef769a--b2b4d1dc) has the CI job 'Python quality gate' red; pr_pass refused (round 3, finding 8f97252a). The functional work is already merged and correct: git.py GitService._resolve_ci_head_sha returns error on httpx.HTTPError (404 stays no_ci_configured); pr_gate.py _resolve_ci_status strict lookup refuses with a retryable invalid_state; tests in tests/unit/services/test_git_pr_ci_status.py and tests/unit/gateway/test_pr_pass_ci_status_guard.py; docs/map/pr-gate-review.md. Locally compose-sync, ruff format/check, reflow_md --check, mypy, xenon, lint-imports and make gate already pass, so the red step is at or after pytest-with-coverage: pytest, the 75% coverage floor, radon, vulture, bandit, pip-audit, deptry, alembic --sql, or foundation-check. Run the FULL make quality (not just make gate), identify the failing step, and fix it with the smallest change. If the cause is the stale base (unrelated files differing from slave) rather than our commits, say so in your dev_notes and fix only what is needed to make the gate green. Commit so the PR head advances.

@github-project-automation github-project-automation Bot moved this to Backlog in RoboCo Kanban Nov 3, 2026
@github-actions github-actions Bot added dependencies pyproject.toml / uv.lock or panel package manifests tests Test suite changes labels Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Thanks for opening your first pull request on RoboCo!

Quick checklist before review (most of these are enforced by CI, but worth a glance):

  • make quality — ruff format check, ruff check, mypy, pytest (≥80% coverage), and the rest of the gate
  • Panel changes pass pnpm lint and pnpm exec tsc --noEmit (run from panel/)
  • No # noqa / # type: ignore shortcuts; pre-existing violations in touched files are fixed
  • Added an entry under ## [Unreleased] in CHANGELOG.md
  • Signed the CLA (the bot will prompt you on this PR)
  • Signed your commits — master requires verified signatures (SSH signing setup)
  • Updated any affected docs under docs/

See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow.

Welcome aboard — a maintainer will review shortly.

… revision 5 with rich cap

Entire-Checkpoint: 01M6KR99Q7B4YX97S87EYRFC94
@github-actions github-actions Bot removed the tests Test suite changes label Nov 4, 2026
@github-actions github-actions Bot added the documentation Docs, README, CHANGELOG, governance files label Nov 4, 2026
@roboco-app
roboco-app Bot merged commit a11c28b into feature/backend/94ef769a--b2b4d1dc Nov 4, 2026
5 of 6 checks passed
@roboco-app
roboco-app Bot deleted the feature/backend/94ef769a--b2b4d1dc--928b741c branch November 4, 2026 17:21
@github-project-automation github-project-automation Bot moved this from Backlog to Done in RoboCo Kanban Nov 4, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cell/backend dependencies pyproject.toml / uv.lock or panel package manifests documentation Docs, README, CHANGELOG, governance files to feature/backend/94ef769a--b2b4d1dc

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant