Repository navigation
[928b741c] Reproduce and fix red Python quality gate on PR #1373 - #1419
Merged
roboco-app[bot] merged 3 commits intoNov 4, 2026
Conversation
…omo tests to promo window
|
Thanks for opening your first pull request on RoboCo! Quick checklist before review (most of these are enforced by CI, but worth a glance):
See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow. Welcome aboard — a maintainer will review shortly. |
rennf93
approved these changes
Nov 3, 2026
… revision 5 with rich cap Entire-Checkpoint: 01M6KR99Q7B4YX97S87EYRFC94
roboco-app
Bot
merged commit Nov 4, 2026
a11c28b
into
feature/backend/94ef769a--b2b4d1dc
5 of 6 checks passed
roboco-app
Bot
deleted the
feature/backend/94ef769a--b2b4d1dc--928b741c
branch
November 4, 2026 17:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1373 (cell branch feature/backend/94ef769a--b2b4d1dc) has the CI job 'Python quality gate' red; pr_pass refused (round 3, finding 8f97252a). The functional work is already merged and correct: git.py GitService._resolve_ci_head_sha returns error on httpx.HTTPError (404 stays no_ci_configured); pr_gate.py _resolve_ci_status strict lookup refuses with a retryable invalid_state; tests in tests/unit/services/test_git_pr_ci_status.py and tests/unit/gateway/test_pr_pass_ci_status_guard.py; docs/map/pr-gate-review.md. Locally compose-sync, ruff format/check, reflow_md --check, mypy, xenon, lint-imports and make gate already pass, so the red step is at or after pytest-with-coverage: pytest, the 75% coverage floor, radon, vulture, bandit, pip-audit, deptry, alembic --sql, or foundation-check. Run the FULL make quality (not just make gate), identify the failing step, and fix it with the smallest change. If the cause is the stale base (unrelated files differing from slave) rather than our commits, say so in your dev_notes and fix only what is needed to make the gate green. Commit so the PR head advances.