Skip to content

[033d7c72] Frontend: fix docs index link and remove stray CI-triage doc - #1413

Merged
roboco-app[bot] merged 1 commit into
feature/main_pm/4559be66from
feature/frontend/4559be66--033d7c72
Nov 3, 2026
Merged

roboco-app[bot] merged 1 commit into
feature/main_pm/4559be66from
feature/frontend/4559be66--033d7c72

Conversation

@roboco-app

@roboco-app roboco-app Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Revision for PR #1393 (root pr_gate bounce). Two docs-only fixes on the assembled branch, verbatim from the findings. F-c963ea03 (nit) docs/frontend/README.md:29: the new feature doc docs/frontend/components/playbook-approved-view.md is not linked from the docs/frontend index; add a one-line link entry for components/playbook-approved-view.md matching the other entries. F-ff7f8585 (minor) docs/frontend/pr-1370-python-gate-base-regression.md: a CI-triage working note for task 04d83ee5 / PR 1370 asserting the Python gate 'will stay red'; it is point-in-time state unrelated to this feature and must not ship to master. Delete the file from the branch. Single small leaf for one frontend developer; no code changes.

…ray CI note (#1409)

Co-authored-by: Frontend Developer 1 <fe-dev-1@roboco.tech>
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Thanks for opening your first pull request on RoboCo!

Quick checklist before review (most of these are enforced by CI, but worth a glance):

  • make quality — ruff format check, ruff check, mypy, pytest (≥80% coverage), and the rest of the gate
  • Panel changes pass pnpm lint and pnpm exec tsc --noEmit (run from panel/)
  • No # noqa / # type: ignore shortcuts; pre-existing violations in touched files are fixed
  • Added an entry under ## [Unreleased] in CHANGELOG.md
  • Signed the CLA (the bot will prompt you on this PR)
  • Signed your commits — master requires verified signatures (SSH signing setup)
  • Updated any affected docs under docs/

See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow.

Welcome aboard — a maintainer will review shortly.

@roboco-app roboco-app Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-path PR-review gate — PASSED ✅

Reviewed by pr_reviewer (RoboCo PR reviewer). Posted by the project bot account; the gate verdict is authoritative in RoboCo.

I checked each criterion against the assembled diff. (1) docs/frontend/README.md line 16 adds "- Playbook approved view — ...". It uses the same bullet/link/em-dash summary form as the sibling component entries, the target file exists on the branch, and the summary matches the doc's intro. (2) docs/frontend/pr-1370-python-gate-base-regression.md is deleted in the diff (34 lines removed) and is absent from the branch worktree. (3) The diff touches only those two files, both under docs/frontend. There are no code changes. This resolves PR #1393 findings F-c963ea03 and F-ff7f8585.

@roboco-app
roboco-app Bot merged commit 7ed1cde into feature/main_pm/4559be66 Nov 3, 2026
10 checks passed
@roboco-app
roboco-app Bot deleted the feature/frontend/4559be66--033d7c72 branch November 3, 2026 17:31
@github-project-automation github-project-automation Bot moved this from Backlog to Done in RoboCo Kanban Nov 3, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cell/frontend documentation Docs, README, CHANGELOG, governance files to feature/main_pm/4559be66

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

0 participants